[dpdk-stable] patch 'net/sfc: fix adapter lock usage on rule creation' has been queued to LTS release 18.11.6

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/17/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/0f527b4d01518354f03662fcdcb53c85b783c0d6

Thanks.

Kevin.

---
>From 0f527b4d01518354f03662fcdcb53c85b783c0d6 Mon Sep 17 00:00:00 2001
From: Ivan Malov <ivan.malov at oktetlabs.ru>
Date: Sun, 3 Nov 2019 13:33:09 +0300
Subject: [PATCH] net/sfc: fix adapter lock usage on rule creation

[ upstream commit 653b285ff11380c44c96a92bedf08fe1614a2fdc ]

The point is that adapter lock has to be held on
list accesses, as well as when talking to the HW.

Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters")

Signed-off-by: Ivan Malov <ivan.malov at oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
---
 drivers/net/sfc/sfc_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
index 371648b0e..1811852fc 100644
--- a/drivers/net/sfc/sfc_flow.c
+++ b/drivers/net/sfc/sfc_flow.c
@@ -2315,8 +2315,8 @@ sfc_flow_create(struct rte_eth_dev *dev,
 		goto fail_bad_value;
 
+	sfc_adapter_lock(sa);
+
 	TAILQ_INSERT_TAIL(&sa->filter.flow_list, flow, entries);
 
-	sfc_adapter_lock(sa);
-
 	if (sa->state == SFC_ADAPTER_STARTED) {
 		rc = sfc_flow_filter_insert(sa, flow);
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-11 21:24:14.324704421 +0000
+++ 0020-net-sfc-fix-adapter-lock-usage-on-rule-creation.patch	2019-12-11 21:24:12.613652333 +0000
@@ -1 +1 @@
-From 653b285ff11380c44c96a92bedf08fe1614a2fdc Mon Sep 17 00:00:00 2001
+From 0f527b4d01518354f03662fcdcb53c85b783c0d6 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 653b285ff11380c44c96a92bedf08fe1614a2fdc ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index e4a9ba0ff..8d636f692 100644
+index 371648b0e..1811852fc 100644
@@ -22 +23 @@
-@@ -2316,8 +2316,8 @@ sfc_flow_create(struct rte_eth_dev *dev,
+@@ -2315,8 +2315,8 @@ sfc_flow_create(struct rte_eth_dev *dev,