[dpdk-stable] patch 'app/eventdev: check function errors' has been queued to LTS release 18.11.6

Kevin Traynor ktraynor at redhat.com
Wed Dec 11 22:26:43 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/17/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/f34a476df925db301df9f74e2b5007392b09ae8a

Thanks.

Kevin.

---
>From f34a476df925db301df9f74e2b5007392b09ae8a Mon Sep 17 00:00:00 2001
From: Pavan Nikhilesh <pbhagavatula at marvell.com>
Date: Fri, 22 Nov 2019 00:52:39 +0530
Subject: [PATCH] app/eventdev: check function errors

[ upstream commit a8d88bfbce00b6f3b1e4c4a3a4464954a21372dd ]

Fix unchecked return values reported by coverity.

Coverity Issue: 336861
Coverity Issue: 349906
Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter")

Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
Acked-by: Jerin Jacob <jerinj at marvell.com>
---
 app/test-eventdev/test_pipeline_common.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
index 5db3ffde1..c988da28c 100644
--- a/app/test-eventdev/test_pipeline_common.c
+++ b/app/test-eventdev/test_pipeline_common.c
@@ -160,4 +160,5 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt)
 {
 	uint16_t i;
+	int ret;
 	uint8_t nb_queues = 1;
 	struct test_pipeline *t = evt_test_priv(test);
@@ -188,5 +189,10 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt)
 		uint32_t caps = 0;
 
-		rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps);
+		ret = rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps);
+		if (ret != 0) {
+			evt_err("failed to get event tx adapter[%d] caps", i);
+			return ret;
+		}
+
 		if (!(caps & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT))
 			t->internal_port = 0;
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-11 21:24:16.718999362 +0000
+++ 0051-app-eventdev-check-function-errors.patch	2019-12-11 21:24:12.710650329 +0000
@@ -1 +1 @@
-From a8d88bfbce00b6f3b1e4c4a3a4464954a21372dd Mon Sep 17 00:00:00 2001
+From f34a476df925db301df9f74e2b5007392b09ae8a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a8d88bfbce00b6f3b1e4c4a3a4464954a21372dd ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -16,2 +17,2 @@
- app/test-eventdev/test_pipeline_common.c | 17 ++++++++++++++---
- 1 file changed, 14 insertions(+), 3 deletions(-)
+ app/test-eventdev/test_pipeline_common.c | 8 +++++++-
+ 1 file changed, 7 insertions(+), 1 deletion(-)
@@ -20 +21 @@
-index 160461fb2..fa91bf229 100644
+index 5db3ffde1..c988da28c 100644
@@ -23 +24,7 @@
-@@ -197,5 +197,10 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt)
+@@ -160,4 +160,5 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt)
+ {
+ 	uint16_t i;
++	int ret;
+ 	uint8_t nb_queues = 1;
+ 	struct test_pipeline *t = evt_test_priv(test);
+@@ -188,5 +189,10 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt)
@@ -35,20 +41,0 @@
-@@ -425,5 +430,5 @@ pipeline_mempool_setup(struct evt_test *test, struct evt_options *opt)
- {
- 	struct test_pipeline *t = evt_test_priv(test);
--	int i;
-+	int i, ret;
- 
- 	if (!opt->mbuf_sz)
-@@ -438,5 +443,11 @@ pipeline_mempool_setup(struct evt_test *test, struct evt_options *opt)
- 
- 		memset(&dev_info, 0, sizeof(dev_info));
--		rte_eth_dev_info_get(i, &dev_info);
-+		ret = rte_eth_dev_info_get(i, &dev_info);
-+		if (ret != 0) {
-+			evt_err("Error during getting device (port %u) info: %s\n",
-+				i, strerror(-ret));
-+			return ret;
-+		}
-+
- 		if (dev_info.rx_desc_lim.nb_mtu_seg_max != UINT16_MAX &&
- 				dev_info.rx_desc_lim.nb_mtu_seg_max != 0) {



More information about the stable mailing list