[dpdk-stable] patch 'test/service: fix wait for service core' has been queued to LTS release 18.11.6

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/17/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/3fd8e91785e8b7f821eb46925397466608e10ef8

Thanks.

Kevin.

---
>From 3fd8e91785e8b7f821eb46925397466608e10ef8 Mon Sep 17 00:00:00 2001
From: Harry van Haaren <harry.van.haaren at intel.com>
Date: Wed, 27 Nov 2019 13:20:27 +0000
Subject: [PATCH] test/service: fix wait for service core

[ upstream commit 505a2b0c64a7f1e087f5a8aaa6940da78c11c81b ]

This commit fixes a sporadic failure of the service_autotest
unit test, as seen in the DPDK CI. The failure occurs as the main test
thread did not wait on the service-thread to return, and allowing it
to read a flag before the service was able to write to it.

The fix changes the wait API call to specific the service-core ID,
and this waits for cores with both ROLE_RTE and ROLE_SERVICE.

The rte_eal_mp_wait_lcore() call does not (and should not) wait
for service cores, so must not be used to wait on service-cores.

Fixes: f038a81e1c56 ("service: add unit tests")

Reported-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
Acked-by: David Marchand <david.marchand at redhat.com>
---
 test/test/test_service_cores.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test/test_service_cores.c b/test/test/test_service_cores.c
index ec31882d9..aa2174a33 100644
--- a/test/test/test_service_cores.c
+++ b/test/test/test_service_cores.c
@@ -484,5 +484,5 @@ service_lcore_en_dis_able(void)
 					slcore_id);
 	TEST_ASSERT_EQUAL(0, ret, "Ex-service core remote launch failed.");
-	rte_eal_mp_wait_lcore();
+	rte_eal_wait_lcore(slcore_id);
 	TEST_ASSERT_EQUAL(1, service_remote_launch_flag,
 			"Ex-service core function call had no effect.");
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-11 21:24:17.985987757 +0000
+++ 0068-test-service-fix-wait-for-service-core.patch	2019-12-11 21:24:12.756649378 +0000
@@ -1 +1 @@
-From 505a2b0c64a7f1e087f5a8aaa6940da78c11c81b Mon Sep 17 00:00:00 2001
+From 3fd8e91785e8b7f821eb46925397466608e10ef8 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 505a2b0c64a7f1e087f5a8aaa6940da78c11c81b ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
- app/test/test_service_cores.c | 2 +-
+ test/test/test_service_cores.c | 2 +-
@@ -27,4 +28,4 @@
-diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c
-index 9fe38f5e0..a922c7ddc 100644
---- a/app/test/test_service_cores.c
-+++ b/app/test/test_service_cores.c
+diff --git a/test/test/test_service_cores.c b/test/test/test_service_cores.c
+index ec31882d9..aa2174a33 100644
+--- a/test/test/test_service_cores.c
++++ b/test/test/test_service_cores.c