[dpdk-stable] patch 'net/ixgbe: remove redundant assignment' has been queued to LTS release 17.11.10

luca.boccassi at gmail.com luca.boccassi at gmail.com
Thu Dec 19 15:32:37 CET 2019


Hi,

FYI, your patch has been queued to LTS release 17.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/21/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 7bddbf66a08d5f379e4db8b9273fcac116e7ef24 Mon Sep 17 00:00:00 2001
From: Yong Wang <wang.yong19 at zte.com.cn>
Date: Fri, 30 Aug 2019 16:45:29 +0800
Subject: [PATCH] net/ixgbe: remove redundant assignment

[ upstream commit e573264c71de3de67e8fa81b0872c10bf4650f15 ]

Since "link.link_duplex" has been assigned to ETH_LINK_FULL_DUPLEX just
before switch statement, the assignment in switch-case statement is
redundant. Remove it.

Fixes: 82113036e4e5 ("ethdev: redesign link speed config")

Signed-off-by: Yong Wang <wang.yong19 at zte.com.cn>
Reviewed-by: Xiaolong Ye <xiaolong.ye at intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index c186ed61a3..fef2270596 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4059,7 +4059,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
 	switch (link_speed) {
 	default:
 	case IXGBE_LINK_SPEED_UNKNOWN:
-		link.link_duplex = ETH_LINK_FULL_DUPLEX;
 		link.link_speed = ETH_SPEED_NUM_100M;
 		break;
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-19 14:32:26.722053590 +0000
+++ 0010-net-ixgbe-remove-redundant-assignment.patch	2019-12-19 14:32:25.413284103 +0000
@@ -1,14 +1,15 @@
-From e573264c71de3de67e8fa81b0872c10bf4650f15 Mon Sep 17 00:00:00 2001
+From 7bddbf66a08d5f379e4db8b9273fcac116e7ef24 Mon Sep 17 00:00:00 2001
 From: Yong Wang <wang.yong19 at zte.com.cn>
 Date: Fri, 30 Aug 2019 16:45:29 +0800
 Subject: [PATCH] net/ixgbe: remove redundant assignment
 
+[ upstream commit e573264c71de3de67e8fa81b0872c10bf4650f15 ]
+
 Since "link.link_duplex" has been assigned to ETH_LINK_FULL_DUPLEX just
 before switch statement, the assignment in switch-case statement is
 redundant. Remove it.
 
 Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
-Cc: stable at dpdk.org
 
 Signed-off-by: Yong Wang <wang.yong19 at zte.com.cn>
 Reviewed-by: Xiaolong Ye <xiaolong.ye at intel.com>
@@ -17,17 +18,17 @@
  1 file changed, 1 deletion(-)
 
 diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
-index 03fc1f7179..f328d7c033 100644
+index c186ed61a3..fef2270596 100644
 --- a/drivers/net/ixgbe/ixgbe_ethdev.c
 +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
-@@ -4138,7 +4138,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
- 			link.link_speed = ETH_SPEED_NUM_10M;
- 		else
- 			link.link_speed = ETH_SPEED_NUM_100M;
+@@ -4059,7 +4059,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
+ 	switch (link_speed) {
+ 	default:
+ 	case IXGBE_LINK_SPEED_UNKNOWN:
 -		link.link_duplex = ETH_LINK_FULL_DUPLEX;
+ 		link.link_speed = ETH_SPEED_NUM_100M;
  		break;
  
- 	case IXGBE_LINK_SPEED_100_FULL:
 -- 
 2.20.1
 


More information about the stable mailing list