[dpdk-stable] patch 'eal: fix log level of error in option register' has been queued to LTS release 18.11.1

Kevin Traynor ktraynor at redhat.com
Thu Feb 7 14:25:15 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/14/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 02985c04b6538002c1702626c3f9fd08ddc0a0c3 Mon Sep 17 00:00:00 2001
From: Gaetan Rivet <gaetan.rivet at 6wind.com>
Date: Thu, 20 Dec 2018 18:06:45 +0100
Subject: [PATCH] eal: fix log level of error in option register

[ upstream commit d3bdefef22b8f653eb9a26093e9a498f2da792d8 ]

INFO is not correct when logging an error.

Fixes: 2395332798d0 ("eal: add option register infrastructure")

Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
---
 lib/librte_eal/common/rte_option.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c
index 088e0fd23..198de6d2e 100644
--- a/lib/librte_eal/common/rte_option.c
+++ b/lib/librte_eal/common/rte_option.c
@@ -37,5 +37,5 @@ rte_option_register(struct rte_option *opt)
 	TAILQ_FOREACH(option, &rte_option_list, next) {
 		if (strcmp(opt->opt_str, option->opt_str) == 0) {
-			RTE_LOG(INFO, EAL, "Option %s has already been registered.\n",
+			RTE_LOG(ERR, EAL, "Option %s has already been registered.\n",
 					opt->opt_str);
 			return;
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-02-07 13:19:55.733210879 +0000
+++ 0009-eal-fix-log-level-of-error-in-option-register.patch	2019-02-07 13:19:55.000000000 +0000
@@ -1,12 +1,13 @@
-From d3bdefef22b8f653eb9a26093e9a498f2da792d8 Mon Sep 17 00:00:00 2001
+From 02985c04b6538002c1702626c3f9fd08ddc0a0c3 Mon Sep 17 00:00:00 2001
 From: Gaetan Rivet <gaetan.rivet at 6wind.com>
 Date: Thu, 20 Dec 2018 18:06:45 +0100
 Subject: [PATCH] eal: fix log level of error in option register
 
+[ upstream commit d3bdefef22b8f653eb9a26093e9a498f2da792d8 ]
+
 INFO is not correct when logging an error.
 
 Fixes: 2395332798d0 ("eal: add option register infrastructure")
-Cc: stable at dpdk.org
 
 Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
 ---
@@ -14,15 +15,15 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c
-index ae8a0e2ca..b2c93b220 100644
+index 088e0fd23..198de6d2e 100644
 --- a/lib/librte_eal/common/rte_option.c
 +++ b/lib/librte_eal/common/rte_option.c
-@@ -57,5 +57,5 @@ rte_option_register(struct rte_option *opt)
+@@ -37,5 +37,5 @@ rte_option_register(struct rte_option *opt)
  	TAILQ_FOREACH(option, &rte_option_list, next) {
- 		if (strcmp(opt->name, option->name) == 0) {
+ 		if (strcmp(opt->opt_str, option->opt_str) == 0) {
 -			RTE_LOG(INFO, EAL, "Option %s has already been registered.\n",
 +			RTE_LOG(ERR, EAL, "Option %s has already been registered.\n",
- 					opt->name);
+ 					opt->opt_str);
  			return;
 -- 
 2.19.0


More information about the stable mailing list