[dpdk-stable] patch 'eal/linux: fix parsing zero socket memory and limits' has been queued to LTS release 18.11.1

Kevin Traynor ktraynor at redhat.com
Thu Feb 7 14:25:56 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/14/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 0122564d8c372d879aa9848675d54dfaa933d464 Mon Sep 17 00:00:00 2001
From: Ilya Maximets <i.maximets at samsung.com>
Date: Tue, 22 Jan 2019 19:27:14 +0300
Subject: [PATCH] eal/linux: fix parsing zero socket memory and limits

[ upstream commit 0a703f0f36c11b6f23fad4fab9e79c308811329d ]

Modern memory mode allowes to not reserve any memory by the
'--socket-mem' option. i.e. it could be possible to specify
zero preallocated memory like '--socket-mem 0'.
Also, it should be possible to configure unlimited memory
allocations by '--socket-limit 0'.

Both cases are impossible now and blocks starting the DPDK
application:

    ./dpdk-app --socket-limit 0 <...>
    EAL: invalid parameters for --socket-limit
    EAL: Invalid 'command line' arguments.
    Unable to initialize DPDK: Invalid argument

Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode")

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
---
 lib/librte_eal/linuxapp/eal/eal.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index 0226b7f6a..30138b638 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -582,8 +582,4 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg)
 	}
 
-	/* check if we have a positive amount of total memory */
-	if (total_mem == 0)
-		return -1;
-
 	return 0;
 }
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-02-07 13:19:56.735202710 +0000
+++ 0050-eal-linux-fix-parsing-zero-socket-memory-and-limits.patch	2019-02-07 13:19:55.000000000 +0000
@@ -1,8 +1,10 @@
-From 0a703f0f36c11b6f23fad4fab9e79c308811329d Mon Sep 17 00:00:00 2001
+From 0122564d8c372d879aa9848675d54dfaa933d464 Mon Sep 17 00:00:00 2001
 From: Ilya Maximets <i.maximets at samsung.com>
 Date: Tue, 22 Jan 2019 19:27:14 +0300
 Subject: [PATCH] eal/linux: fix parsing zero socket memory and limits
 
+[ upstream commit 0a703f0f36c11b6f23fad4fab9e79c308811329d ]
+
 Modern memory mode allowes to not reserve any memory by the
 '--socket-mem' option. i.e. it could be possible to specify
 zero preallocated memory like '--socket-mem 0'.
@@ -18,7 +20,6 @@
     Unable to initialize DPDK: Invalid argument
 
 Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode")
-Cc: stable at dpdk.org
 
 Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
 Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
@@ -27,10 +28,10 @@
  1 file changed, 4 deletions(-)
 
 diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
-index a386829f3..13f401684 100644
+index 0226b7f6a..30138b638 100644
 --- a/lib/librte_eal/linuxapp/eal/eal.c
 +++ b/lib/librte_eal/linuxapp/eal/eal.c
-@@ -583,8 +583,4 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg)
+@@ -582,8 +582,4 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg)
  	}
  
 -	/* check if we have a positive amount of total memory */


More information about the stable mailing list