[dpdk-stable] patch 'doc: add dependency for PDF in contributing guide' has been queued to LTS release 18.11.1

Kevin Traynor ktraynor at redhat.com
Thu Feb 7 14:26:12 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/14/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From d21965318f1913905ae7fca32b466cc18d0607f9 Mon Sep 17 00:00:00 2001
From: Rami Rosen <ramirose at gmail.com>
Date: Sun, 20 Jan 2019 20:29:47 +0200
Subject: [PATCH] doc: add dependency for PDF in contributing guide

[ upstream commit 63a71926e9f498bc121cec30de1ccae6970da612 ]

There is a missing depenency for building docs with "make doc-guides-pdf".
This causes it to break with "make[3]: latexmk: Command not found". This
was observed and reported in https://bugs.dpdk.org/show_bug.cgi?id=182
This patch fixes this issue by adding the latexmk package dependency in
sub-section 4.3.1 of the contributing guide ("Dependencies").

Bugzilla ID: 182

Signed-off-by: Rami Rosen <ramirose at gmail.com>
---
 doc/guides/contributing/documentation.rst | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/doc/guides/contributing/documentation.rst b/doc/guides/contributing/documentation.rst
index c28a95c34..c72280a29 100644
--- a/doc/guides/contributing/documentation.rst
+++ b/doc/guides/contributing/documentation.rst
@@ -205,4 +205,17 @@ The main required packages can be installed as follows:
    sudo dnf     -y install texlive-collection-latexextra
 
+`Latexmk <http://personal.psu.edu/jcc8/software/latexmk-jcc/>`_ is a perl script
+for running LaTeX for resolving cross references,
+and it also runs auxiliary programs like bibtex, makeindex if necessary, and dvips.
+It has also a number of other useful capabilities (see man 1 latexmk).
+
+.. code-block:: console
+
+   # Ubuntu/Debian.
+   sudo apt-get -y install latexmk
+
+   # Red Hat/Fedora.
+   sudo dnf     -y install latexmk
+
 
 Build commands
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-02-07 13:19:57.159938742 +0000
+++ 0066-doc-add-dependency-for-PDF-in-contributing-guide.patch	2019-02-07 13:19:55.000000000 +0000
@@ -1,8 +1,10 @@
-From 63a71926e9f498bc121cec30de1ccae6970da612 Mon Sep 17 00:00:00 2001
+From d21965318f1913905ae7fca32b466cc18d0607f9 Mon Sep 17 00:00:00 2001
 From: Rami Rosen <ramirose at gmail.com>
 Date: Sun, 20 Jan 2019 20:29:47 +0200
 Subject: [PATCH] doc: add dependency for PDF in contributing guide
 
+[ upstream commit 63a71926e9f498bc121cec30de1ccae6970da612 ]
+
 There is a missing depenency for building docs with "make doc-guides-pdf".
 This causes it to break with "make[3]: latexmk: Command not found". This
 was observed and reported in https://bugs.dpdk.org/show_bug.cgi?id=182
@@ -10,7 +12,6 @@
 sub-section 4.3.1 of the contributing guide ("Dependencies").
 
 Bugzilla ID: 182
-Cc: stable at dpdk.org
 
 Signed-off-by: Rami Rosen <ramirose at gmail.com>
 ---


More information about the stable mailing list