[dpdk-stable] patch 'eal: explicit cast of core id when getting index' has been queued to LTS release 17.11.5

Yongseok Koh yskoh at mellanox.com
Thu Jan 3 09:13:25 CET 2019


Hi,

FYI, your patch has been queued to LTS release 17.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/04/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Yongseok

---
>From 8b24bc6e6ed66efab951df2c15fe0dd987dd4198 Mon Sep 17 00:00:00 2001
From: Andy Green <andy at warmcat.com>
Date: Sat, 12 May 2018 09:59:07 +0800
Subject: [PATCH] eal: explicit cast of core id when getting index

[ upstream commit ef3c7b50ff39a37a93ecea47481d392d8fcb2936 ]

rte_lcore.h: In function 'rte_lcore_index':
rte_lcore.h:122:14:
warning: conversion to 'int' from 'unsigned int' may change
the sign of the result [-Wsign-conversion]
   lcore_id = rte_lcore_id();

Fixes: 5583037a7950 ("eal: get relative core index")

Signed-off-by: Andy Green <andy at warmcat.com>
Reviewed-by: Stephen Hemminger <stephen at networkplumber.org>
---
 lib/librte_eal/common/include/rte_lcore.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h
index 3735da0c7..0dd710de5 100644
--- a/lib/librte_eal/common/include/rte_lcore.h
+++ b/lib/librte_eal/common/include/rte_lcore.h
@@ -136,7 +136,7 @@ rte_lcore_index(int lcore_id)
 	if (lcore_id >= RTE_MAX_LCORE)
 		return -1;
 	if (lcore_id < 0)
-		lcore_id = rte_lcore_id();
+		lcore_id = (int)rte_lcore_id();
 	return lcore_config[lcore_id].core_index;
 }
 
-- 
2.11.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-02 23:59:12.213286850 -0800
+++ 0002-eal-explicit-cast-of-core-id-when-getting-index.patch	2019-01-02 23:59:12.001814000 -0800
@@ -1,8 +1,10 @@
-From ef3c7b50ff39a37a93ecea47481d392d8fcb2936 Mon Sep 17 00:00:00 2001
+From 8b24bc6e6ed66efab951df2c15fe0dd987dd4198 Mon Sep 17 00:00:00 2001
 From: Andy Green <andy at warmcat.com>
 Date: Sat, 12 May 2018 09:59:07 +0800
 Subject: [PATCH] eal: explicit cast of core id when getting index
 
+[ upstream commit ef3c7b50ff39a37a93ecea47481d392d8fcb2936 ]
+
 rte_lcore.h: In function 'rte_lcore_index':
 rte_lcore.h:122:14:
 warning: conversion to 'int' from 'unsigned int' may change
@@ -10,7 +12,6 @@
    lcore_id = rte_lcore_id();
 
 Fixes: 5583037a7950 ("eal: get relative core index")
-Cc: stable at dpdk.org
 
 Signed-off-by: Andy Green <andy at warmcat.com>
 Reviewed-by: Stephen Hemminger <stephen at networkplumber.org>
@@ -19,10 +20,10 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h
-index 1a2f37eaa..6e09d9181 100644
+index 3735da0c7..0dd710de5 100644
 --- a/lib/librte_eal/common/include/rte_lcore.h
 +++ b/lib/librte_eal/common/include/rte_lcore.h
-@@ -119,7 +119,7 @@ rte_lcore_index(int lcore_id)
+@@ -136,7 +136,7 @@ rte_lcore_index(int lcore_id)
  	if (lcore_id >= RTE_MAX_LCORE)
  		return -1;
  	if (lcore_id < 0)


More information about the stable mailing list