[dpdk-stable] patch 'ethdev: explicit cast of queue count return' has been queued to LTS release 17.11.5

Yongseok Koh yskoh at mellanox.com
Thu Jan 3 09:13:52 CET 2019


Hi,

FYI, your patch has been queued to LTS release 17.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/04/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Yongseok

---
>From 2cde5ec07db9287bb077ad2dfc2cc9820056fae2 Mon Sep 17 00:00:00 2001
From: Andy Green <andy at warmcat.com>
Date: Fri, 18 May 2018 21:02:38 +0800
Subject: [PATCH] ethdev: explicit cast of queue count return

[ upstream commit 45d1be93b9020dfe9c1f3e81822621580312dcc3 ]

GCC 8.1 produces a warning:
rte_ethdev.h: In function 'rte_eth_rx_queue_count':
rte_ethdev.h:3882:10: warning: conversion to 'int' from 'uint32_t'
{aka 'unsigned int'} may change the sign of the result [-Wsign-conversion]
  return (*dev->dev_ops->rx_queue_count)(dev, queue_id);
         ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 33cf6be04d60 ("ethdev: add sanity checks to functions")

Signed-off-by: Andy Green <andy at warmcat.com>
---
 lib/librte_ether/rte_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index bbca590d4..65cb04755 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -2935,7 +2935,7 @@ rte_eth_rx_queue_count(uint16_t port_id, uint16_t queue_id)
 	if (queue_id >= dev->data->nb_rx_queues)
 		return -EINVAL;
 
-	return (*dev->dev_ops->rx_queue_count)(dev, queue_id);
+	return (int)(*dev->dev_ops->rx_queue_count)(dev, queue_id);
 }
 
 /**
-- 
2.11.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-02 23:59:13.620667292 -0800
+++ 0029-ethdev-explicit-cast-of-queue-count-return.patch	2019-01-02 23:59:12.091815000 -0800
@@ -1,8 +1,10 @@
-From 45d1be93b9020dfe9c1f3e81822621580312dcc3 Mon Sep 17 00:00:00 2001
+From 2cde5ec07db9287bb077ad2dfc2cc9820056fae2 Mon Sep 17 00:00:00 2001
 From: Andy Green <andy at warmcat.com>
 Date: Fri, 18 May 2018 21:02:38 +0800
 Subject: [PATCH] ethdev: explicit cast of queue count return
 
+[ upstream commit 45d1be93b9020dfe9c1f3e81822621580312dcc3 ]
+
 GCC 8.1 produces a warning:
 rte_ethdev.h: In function 'rte_eth_rx_queue_count':
 rte_ethdev.h:3882:10: warning: conversion to 'int' from 'uint32_t'
@@ -11,18 +13,17 @@
          ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 Fixes: 33cf6be04d60 ("ethdev: add sanity checks to functions")
-Cc: stable at dpdk.org
 
 Signed-off-by: Andy Green <andy at warmcat.com>
 ---
- lib/librte_ethdev/rte_ethdev.h | 2 +-
+ lib/librte_ether/rte_ethdev.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
-diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
-index f8815e994..d52c1bed9 100644
---- a/lib/librte_ethdev/rte_ethdev.h
-+++ b/lib/librte_ethdev/rte_ethdev.h
-@@ -3874,7 +3874,7 @@ rte_eth_rx_queue_count(uint16_t port_id, uint16_t queue_id)
+diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
+index bbca590d4..65cb04755 100644
+--- a/lib/librte_ether/rte_ethdev.h
++++ b/lib/librte_ether/rte_ethdev.h
+@@ -2935,7 +2935,7 @@ rte_eth_rx_queue_count(uint16_t port_id, uint16_t queue_id)
  	if (queue_id >= dev->data->nb_rx_queues)
  		return -EINVAL;
  


More information about the stable mailing list