[dpdk-stable] patch 'log: add missing experimental tag' has been queued to LTS release 18.11.1

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/11/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From a4bca176eea3a5fc71e2e42094c806037f84c15f Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Tue, 4 Dec 2018 09:28:31 +0100
Subject: [PATCH] log: add missing experimental tag

[ upstream commit a8499f65a1d116ffb25db48abbe3bbaefa7cf120 ]

When rte_log_register_type_and_pick_level() has been introduced, it has
been correctly added to the EXPERIMENTAL section of the eal map and the
symbol itself has been marked at its definition.

However, the declaration of this symbol in rte_log.h is missing the
__rte_experimental tag.
Because of this, a user can try to call this symbol without being aware
this is an experimental api (neither compilation nor link warning).

Fixes: b22e77c02620 ("eal: register log type and pick level from args")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Neil Horman <nhorman at tuxdriver.com>
---
 lib/librte_eal/common/include/rte_log.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h
index 2f789cb90..f334efce4 100644
--- a/lib/librte_eal/common/include/rte_log.h
+++ b/lib/librte_eal/common/include/rte_log.h
@@ -25,4 +25,5 @@ extern "C" {
 #include <rte_common.h>
 #include <rte_config.h>
+#include <rte_compat.h>
 
 struct rte_log_dynamic_type;
@@ -227,4 +228,5 @@ int rte_log_register(const char *name);
  *    - <0: rte_log_register() error value
  */
+__rte_experimental
 int rte_log_register_type_and_pick_level(const char *name, uint32_t level_def);
 
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-04 13:23:07.534676260 +0000
+++ 0003-log-add-missing-experimental-tag.patch	2019-01-04 13:23:07.000000000 +0000
@@ -1,8 +1,10 @@
-From a8499f65a1d116ffb25db48abbe3bbaefa7cf120 Mon Sep 17 00:00:00 2001
+From a4bca176eea3a5fc71e2e42094c806037f84c15f Mon Sep 17 00:00:00 2001
 From: David Marchand <david.marchand at redhat.com>
 Date: Tue, 4 Dec 2018 09:28:31 +0100
 Subject: [PATCH] log: add missing experimental tag
 
+[ upstream commit a8499f65a1d116ffb25db48abbe3bbaefa7cf120 ]
+
 When rte_log_register_type_and_pick_level() has been introduced, it has
 been correctly added to the EXPERIMENTAL section of the eal map and the
 symbol itself has been marked at its definition.
@@ -13,7 +15,6 @@
 this is an experimental api (neither compilation nor link warning).
 
 Fixes: b22e77c02620 ("eal: register log type and pick level from args")
-Cc: stable at dpdk.org
 
 Signed-off-by: David Marchand <david.marchand at redhat.com>
 Acked-by: Neil Horman <nhorman at tuxdriver.com>