[dpdk-stable] patch 'eal: fix leak on multi-process request error' has been queued to LTS release 18.11.1

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/11/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 08eb5669bf91a89e1ed0138e4de012f32dabad5b Mon Sep 17 00:00:00 2001
From: Gao Feng <davidfgao at tencent.com>
Date: Wed, 5 Dec 2018 10:50:25 +0800
Subject: [PATCH] eal: fix leak on multi-process request error

[ upstream commit e14bc93e8f231455ac7ffb45189f8dedcc45276d ]

When rte_eal_alarm_set failed, need to free the bundle mem in the
error handler of handle_primary_request and handle_secondary_request.

Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
Fixes: ac9e4a17370f ("eal: support attach/detach shared device from secondary")

Signed-off-by: Gao Feng <davidfgao at tencent.com>
Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
---
 lib/librte_eal/common/hotplug_mp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/librte_eal/common/hotplug_mp.c b/lib/librte_eal/common/hotplug_mp.c
index 070e2e0c2..9d610a8a2 100644
--- a/lib/librte_eal/common/hotplug_mp.c
+++ b/lib/librte_eal/common/hotplug_mp.c
@@ -209,4 +209,6 @@ handle_secondary_request(const struct rte_mp_msg *msg, const void *peer)
 	if (ret != 0) {
 		RTE_LOG(ERR, EAL, "failed to add mp task\n");
+		free(bundle->peer);
+		free(bundle);
 		return send_response_to_secondary(req, ret, peer);
 	}
@@ -333,4 +335,6 @@ handle_primary_request(const struct rte_mp_msg *msg, const void *peer)
 	ret = rte_eal_alarm_set(1, __handle_primary_request, bundle);
 	if (ret != 0) {
+		free(bundle->peer);
+		free(bundle);
 		resp->result = ret;
 		ret = rte_mp_reply(&mp_resp, peer);
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-04 13:23:08.119461650 +0000
+++ 0028-eal-fix-leak-on-multi-process-request-error.patch	2019-01-04 13:23:07.000000000 +0000
@@ -1,14 +1,15 @@
-From e14bc93e8f231455ac7ffb45189f8dedcc45276d Mon Sep 17 00:00:00 2001
+From 08eb5669bf91a89e1ed0138e4de012f32dabad5b Mon Sep 17 00:00:00 2001
 From: Gao Feng <davidfgao at tencent.com>
 Date: Wed, 5 Dec 2018 10:50:25 +0800
 Subject: [PATCH] eal: fix leak on multi-process request error
 
+[ upstream commit e14bc93e8f231455ac7ffb45189f8dedcc45276d ]
+
 When rte_eal_alarm_set failed, need to free the bundle mem in the
 error handler of handle_primary_request and handle_secondary_request.
 
 Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
 Fixes: ac9e4a17370f ("eal: support attach/detach shared device from secondary")
-Cc: stable at dpdk.org
 
 Signed-off-by: Gao Feng <davidfgao at tencent.com>
 Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>