[dpdk-stable] patch 'net/cxgbe: skip parsing match items with no spec' has been queued to LTS release 18.11.1

Kevin Traynor ktraynor at redhat.com
Fri Jan 4 14:24:41 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/11/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From ca5a94bbe74fc98ff897fd71f5311f3363774bef Mon Sep 17 00:00:00 2001
From: Rahul Lakkireddy <rahul.lakkireddy at chelsio.com>
Date: Sat, 15 Dec 2018 00:31:54 +0530
Subject: [PATCH] net/cxgbe: skip parsing match items with no spec

[ upstream commit cadce5ee8aec5236d06474a94db0ba0ec6a48321 ]

Skip parsing pattern match items that have no spec. This fixes NULL
dereference when accessing their non-existent spec.

Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows")

Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy at chelsio.com>
---
 drivers/net/cxgbe/cxgbe_flow.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers/net/cxgbe/cxgbe_flow.c
index 4deaff8f2..7b87bdf58 100644
--- a/drivers/net/cxgbe/cxgbe_flow.c
+++ b/drivers/net/cxgbe/cxgbe_flow.c
@@ -733,4 +733,8 @@ cxgbe_rtef_parse_items(struct rte_flow *flow,
 			repeat[i->type] = 1;
 
+			/* No spec found for this pattern item. Skip it */
+			if (!i->spec)
+				break;
+
 			/* validate the item */
 			ret = cxgbe_validate_item(i, e);
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-04 13:23:08.886072478 +0000
+++ 0059-net-cxgbe-skip-parsing-match-items-with-no-spec.patch	2019-01-04 13:23:07.000000000 +0000
@@ -1,13 +1,14 @@
-From cadce5ee8aec5236d06474a94db0ba0ec6a48321 Mon Sep 17 00:00:00 2001
+From ca5a94bbe74fc98ff897fd71f5311f3363774bef Mon Sep 17 00:00:00 2001
 From: Rahul Lakkireddy <rahul.lakkireddy at chelsio.com>
 Date: Sat, 15 Dec 2018 00:31:54 +0530
 Subject: [PATCH] net/cxgbe: skip parsing match items with no spec
 
+[ upstream commit cadce5ee8aec5236d06474a94db0ba0ec6a48321 ]
+
 Skip parsing pattern match items that have no spec. This fixes NULL
 dereference when accessing their non-existent spec.
 
 Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows")
-Cc: stable at dpdk.org
 
 Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy at chelsio.com>
 ---


More information about the stable mailing list