[dpdk-stable] patch 'net/vhost: fix double free of MAC address' has been queued to LTS release 18.11.1

Hideyuki Yamashita yamashita.hideyuki at po.ntt-tx.co.jp
Mon Jan 7 01:04:28 CET 2019


Hello Kevin,

Thanks for your answering me.

I understand that now my patch is queued to LTS 18.11.1.

I would like to ask general rules which kind of patch is queued
to LTS and which is not.
(If I CCed stable at dpdk.org when I submmit patch, it is automatically 
queued? If that is true then how (or where) can I watch the status
of my patch?)

The reason why I ask this is that from user perspective
I want as much patches be queued to LTS so that we can 
use LTS as stable one.

Thanks!

BR,
Hideyuki Yamashita
NTT TechnoCross

> Hi,
> 
> FYI, your patch has been queued to LTS release 18.11.1
> 
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> It will be pushed if I get no objections before 01/11/19. So please
> shout if anyone has objections.
> 
> Also note that after the patch there's a diff of the upstream commit vs the
> patch applied to the branch. This will indicate if there was any rebasing
> needed to apply to the stable branch. If there were code changes for rebasing
> (ie: not only metadata diffs), please double check that the rebase was
> correctly done.
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> From 00ffa031bda23be8e1d558d8ed981389628bc543 Mon Sep 17 00:00:00 2001
> From: Hideyuki Yamashita <yamashita.hideyuki at po.ntt-tx.co.jp>
> Date: Wed, 19 Dec 2018 13:37:18 +0900
> Subject: [PATCH] net/vhost: fix double free of MAC address
> 
> [ upstream commit 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 ]
> 
> The common data freeing has been moved to rte_eth_dev_release_port(),
> so freeing mac_addrs like this in eth_dev_close() is unnecessary and
> will cause double free.
> 
> Fixes: e16adf08e54d ("ethdev: free all common data when releasing port")
> 
> Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki at po.ntt-tx.co.jp>
> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi at lab.ntt.co.jp>
> Reviewed-by: Tiwei Bie <tiwei.bie at intel.com>
> ---
>  drivers/net/vhost/rte_eth_vhost.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index 42bdfcbd5..b2cda0483 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1001,5 +1001,4 @@ eth_dev_close(struct rte_eth_dev *dev)
>  			rte_free(dev->data->tx_queues[i]);
>  
> -	rte_free(dev->data->mac_addrs);
>  	free(internal->dev_name);
>  	free(internal->iface_name);
> -- 
> 2.19.0
> 
> ---
>   Diff of the applied patch vs upstream commit (please double-check if non-empty:
> ---
> --- -	2019-01-04 13:23:09.004712018 +0000
> +++ 0064-net-vhost-fix-double-free-of-MAC-address.patch	2019-01-04 13:23:07.000000000 +0000
> @@ -1,14 +1,15 @@
> -From 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 Mon Sep 17 00:00:00 2001
> +From 00ffa031bda23be8e1d558d8ed981389628bc543 Mon Sep 17 00:00:00 2001
>  From: Hideyuki Yamashita <yamashita.hideyuki at po.ntt-tx.co.jp>
>  Date: Wed, 19 Dec 2018 13:37:18 +0900
>  Subject: [PATCH] net/vhost: fix double free of MAC address
>  
> +[ upstream commit 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 ]
> +
>  The common data freeing has been moved to rte_eth_dev_release_port(),
>  so freeing mac_addrs like this in eth_dev_close() is unnecessary and
>  will cause double free.
>  
>  Fixes: e16adf08e54d ("ethdev: free all common data when releasing port")
> -Cc: stable at dpdk.org
>  
>  Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki at po.ntt-tx.co.jp>
>  Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi at lab.ntt.co.jp>




More information about the stable mailing list