[dpdk-stable] patch 'doc: fix NUMA library name in Linux guide' has been queued to LTS release 17.11.5

Yongseok Koh yskoh at mellanox.com
Tue Jan 8 19:51:19 CET 2019


I've explained the reason in the other email.

Re-applied to stable/17.11


Thanks,
Yongseok

> On Jan 8, 2019, at 8:48 AM, Burakov, Anatoly <anatoly.burakov at intel.com> wrote:
> 
> Why is this being reverted? Even though the patch was sent for newer release, the patch is still valid.
> 
> Thanks,
> Anatoly
> 
> 
>> -----Original Message-----
>> From: Yongseok Koh [mailto:yskoh at mellanox.com]
>> Sent: Thursday, December 20, 2018 12:21 AM
>> To: Yong Wang <wang.yong19 at zte.com.cn>
>> Cc: Burakov, Anatoly <anatoly.burakov at intel.com>; dpdk stable
>> <stable at dpdk.org>
>> Subject: Re: [dpdk-stable] patch 'doc: fix NUMA library name in Linux guide'
>> has been queued to LTS release 17.11.5
>> 
>> Hi,
>> 
>> This patch is being removed from stable/17.11 as it was mistakenly merged.
>> Patches having 'fix' keyword in the title were merged even though those
>> don't have "Cc: stable at dpdk.org" tag in the commit message.
>> 
>> If you think this patch is still needed for stable/17.11, please let me know.
>> Then I'll take it back.
>> 
>> 
>> Thanks,
>> Yongseok
>> 
>> 
>>> On Nov 29, 2018, at 3:11 PM, Yongseok Koh <yskoh at mellanox.com>
>> wrote:
>>> 
>>> Hi,
>>> 
>>> FYI, your patch has been queued to LTS release 17.11.5
>>> 
>>> Note it hasn't been pushed to
>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd
>> k.org%2Fbrowse%2Fdpdk-
>> stable&data=02%7C01%7Cyskoh%40mellanox.com%7C3097861863494e
>> 253cd808d65650a18a%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7
>> C636791301631687810&sdata=1IIjuHiB%2FDLkwrxCowghwJs4B3lC%2BjR
>> 8lgbFRceJS1Y%3D&reserved=0 yet.
>>> It will be pushed if I get no objections before 12/01/18. So please
>>> shout if anyone has objections.
>>> 
>>> Also note that after the patch there's a diff of the upstream commit
>>> vs the patch applied to the branch. If the code is different (ie: not
>>> only metadata diffs), due for example to a change in context or macro
>> names, please double check it.
>>> 
>>> Thanks.
>>> 
>>> Yongseok
>>> 
>>> ---
>>> From 07f6eef828917fe2716f24b54dcac2406cacf489 Mon Sep 17 00:00:00
>> 2001
>>> From: Yong Wang <wang.yong19 at zte.com.cn>
>>> Date: Tue, 6 Nov 2018 21:40:52 -0500
>>> Subject: [PATCH] doc: fix NUMA library name in Linux guide
>>> 
>>> [ upstream commit ee57170c4acb7b477091948caa8ea9e887222867 ]
>>> 
>>> The library for handling NUMA is not libnuma-devel, but numactl-devel
>>> in Red Hat/Fedora and libnuma-dev in Debian/Ubuntu.
>>> 
>>> Signed-off-by: Yong Wang <wang.yong19 at zte.com.cn>
>>> Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
>>> ---
>>> doc/guides/linux_gsg/sys_reqs.rst | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/doc/guides/linux_gsg/sys_reqs.rst
>>> b/doc/guides/linux_gsg/sys_reqs.rst
>>> index 3e7fe6373..7a91b31c7 100644
>>> --- a/doc/guides/linux_gsg/sys_reqs.rst
>>> +++ b/doc/guides/linux_gsg/sys_reqs.rst
>>> @@ -91,7 +91,11 @@ Compilation of the DPDK
>>>       x86_x32 ABI is currently supported with distribution packages only on
>> Ubuntu
>>>       higher than 13.10 or recent Debian distribution. The only supported
>> compiler is gcc 4.9+.
>>> 
>>> -*   libnuma-devel - library for handling NUMA (Non Uniform Memory
>> Access).
>>> +*   Library for handling NUMA (Non Uniform Memory Access).
>>> +
>>> +    * numactl-devel in Red Hat/Fedora;
>>> +
>>> +    * libnuma-dev in Debian/Ubuntu;
>>> 
>>> *   Python, version 2.7+ or 3.2+, to use various helper scripts included in the
>> DPDK package.
>>> 
>>> --
>>> 2.11.0
>>> 
>>> ---
>>> Diff of the applied patch vs upstream commit (please double-check if non-
>> empty:
>>> ---
>>> --- -	2018-11-29 15:01:50.406698523 -0800
>>> +++ 0119-doc-fix-NUMA-library-name-in-Linux-guide.patch	2018-11-29
>> 15:01:45.315956000 -0800
>>> @@ -1,8 +1,10 @@
>>> -From ee57170c4acb7b477091948caa8ea9e887222867 Mon Sep 17 00:00:00
>>> 2001
>>> +From 07f6eef828917fe2716f24b54dcac2406cacf489 Mon Sep 17 00:00:00
>>> +2001
>>> From: Yong Wang <wang.yong19 at zte.com.cn>
>>> Date: Tue, 6 Nov 2018 21:40:52 -0500
>>> Subject: [PATCH] doc: fix NUMA library name in Linux guide
>>> 
>>> +[ upstream commit ee57170c4acb7b477091948caa8ea9e887222867 ]
>>> +
>>> The library for handling NUMA is not libnuma-devel, but numactl-devel
>>> in Red Hat/Fedora and libnuma-dev in Debian/Ubuntu.
>>> 
>>> @@ -13,10 +15,10 @@
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/doc/guides/linux_gsg/sys_reqs.rst
>>> b/doc/guides/linux_gsg/sys_reqs.rst
>>> -index 96f5ce9b5..29c5f47a5 100644
>>> +index 3e7fe6373..7a91b31c7 100644
>>> --- a/doc/guides/linux_gsg/sys_reqs.rst
>>> +++ b/doc/guides/linux_gsg/sys_reqs.rst
>>> -@@ -64,7 +64,11 @@ Compilation of the DPDK
>>> +@@ -91,7 +91,11 @@ Compilation of the DPDK
>>>        x86_x32 ABI is currently supported with distribution packages only on
>> Ubuntu
>>>        higher than 13.10 or recent Debian distribution. The only supported
>> compiler is gcc 4.9+.



More information about the stable mailing list