[dpdk-stable] [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

Thomas Monjalon thomas at monjalon.net
Tue Jan 15 02:53:28 CET 2019


14/01/2019 15:21, Bruce Richardson:
> On Mon, Jan 14, 2019 at 06:04:35AM +0000, Chaitanya Babu Talluri wrote:
> > Strcat does not check the destination length and there might be
> > chances of string overflow so insted of strcat, strncat is used.
[...]
> 
> While I believe this is correct, this (and the changes below) would be a
> lot neater using strlcat function. We should perhaps look to add strlcat
> alongside strlcpy for DPDK use.

Yes it looks reasonnable.




More information about the stable mailing list