[dpdk-stable] [PATCH 17.11 3/3] net/sfc/base: fix PreFAST warnings because of unused return

Andrew Rybchenko arybchenko at solarflare.com
Mon Jan 21 07:59:07 CET 2019


On 1/19/19 3:42 AM, Yongseok Koh wrote:
>> On Jan 18, 2019, at 7:59 AM, Andrew Rybchenko <arybchenko at solarflare.com> wrote:
>>
>> From: Martin Harvey <mharvey at solarflare.com>
>>
>> [ backported from upstream commit f394c63d2d33449443a42e86da826c38e98d59b3 ]
>>
>> Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base")
>> Fixes: d96a34d165b1 ("net/sfc/base: import NVRAM support")
>> Fixes: e7cd430c864f ("net/sfc/base: import SFN7xxx family support")
>>
>> Signed-off-by: Martin Harvey <mharvey at solarflare.com>
>> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
>> ---
> Compilation failed. Two errors for the label.
>
> drivers/net/sfc/base/ef10_filter.c: In function ‘ef10_filter_insert_all_multicast’:
> drivers/net/sfc/base/ef10_filter.c:1247:3: error: label ‘fail2’ used but not defined
>     goto fail2;
>     ^
> drivers/net/sfc/base/ef10_filter.c: In function ‘ef10_filter_get_workarounds’:
> drivers/net/sfc/base/ef10_filter.c:1409:1: error: label ‘fail2’ defined but not used [-Werror=unused-label]
>   fail2:
>   ^
> cc1: all warnings being treated as errors
> make[4]: *** [ef10_filter.o] Error 1

I'm sorry for it - forgot to refresh the patch before sending.

Thanks a lot,
Andrew.


More information about the stable mailing list