[dpdk-stable] patch 'app/bbdev: fix return value check' has been queued to LTS release 18.11.1

Kevin Traynor ktraynor at redhat.com
Thu Jan 31 16:48:19 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/07/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 89be0f56e1b3ec4939a09f8843acaa1a674a5508 Mon Sep 17 00:00:00 2001
From: Amr Mokhtar <amr.mokhtar at intel.com>
Date: Wed, 2 Jan 2019 14:09:02 +0000
Subject: [PATCH] app/bbdev: fix return value check

[ upstream commit 4280cd350bab73d06c454d259d782f3a68b581d6 ]

Added assert check for rte_bbdev_*_op_alloc_bulk in bbdev test app

Coverity issue: 328516, 328525
Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")

Signed-off-by: Amr Mokhtar <amr.mokhtar at intel.com>
---
 app/test-bbdev/test_bbdev_perf.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index fbe6cc91c..fa26deb1e 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -1954,5 +1954,8 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs,
 			burst_sz = num_to_process - dequeued;
 
-		rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz);
+		ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz);
+		TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops",
+				burst_sz);
+
 		if (test_vector.op_type != RTE_BBDEV_OP_NONE)
 			copy_reference_dec_op(ops_enq, burst_sz, dequeued,
@@ -2036,5 +2039,8 @@ offload_latency_test_enc(struct rte_mempool *mempool, struct test_buffers *bufs,
 			burst_sz = num_to_process - dequeued;
 
-		rte_bbdev_enc_op_alloc_bulk(mempool, ops_enq, burst_sz);
+		ret = rte_bbdev_enc_op_alloc_bulk(mempool, ops_enq, burst_sz);
+		TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops",
+				burst_sz);
+
 		if (test_vector.op_type != RTE_BBDEV_OP_NONE)
 			copy_reference_enc_op(ops_enq, burst_sz, dequeued,
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-31 15:44:06.004268292 +0000
+++ 0011-app-bbdev-fix-return-value-check.patch	2019-01-31 15:44:05.000000000 +0000
@@ -1,13 +1,14 @@
-From 4280cd350bab73d06c454d259d782f3a68b581d6 Mon Sep 17 00:00:00 2001
+From 89be0f56e1b3ec4939a09f8843acaa1a674a5508 Mon Sep 17 00:00:00 2001
 From: Amr Mokhtar <amr.mokhtar at intel.com>
 Date: Wed, 2 Jan 2019 14:09:02 +0000
 Subject: [PATCH] app/bbdev: fix return value check
 
+[ upstream commit 4280cd350bab73d06c454d259d782f3a68b581d6 ]
+
 Added assert check for rte_bbdev_*_op_alloc_bulk in bbdev test app
 
 Coverity issue: 328516, 328525
 Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
-Cc: stable at dpdk.org
 
 Signed-off-by: Amr Mokhtar <amr.mokhtar at intel.com>
 ---
@@ -15,10 +16,10 @@
  1 file changed, 8 insertions(+), 2 deletions(-)
 
 diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
-index 1c4a6452f..d18ddae0e 100644
+index fbe6cc91c..fa26deb1e 100644
 --- a/app/test-bbdev/test_bbdev_perf.c
 +++ b/app/test-bbdev/test_bbdev_perf.c
-@@ -2105,5 +2105,8 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs,
+@@ -1954,5 +1954,8 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs,
  			burst_sz = num_to_process - dequeued;
  
 -		rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz);
@@ -28,7 +29,7 @@
 +
  		if (test_vector.op_type != RTE_BBDEV_OP_NONE)
  			copy_reference_dec_op(ops_enq, burst_sz, dequeued,
-@@ -2187,5 +2190,8 @@ offload_latency_test_enc(struct rte_mempool *mempool, struct test_buffers *bufs,
+@@ -2036,5 +2039,8 @@ offload_latency_test_enc(struct rte_mempool *mempool, struct test_buffers *bufs,
  			burst_sz = num_to_process - dequeued;
  
 -		rte_bbdev_enc_op_alloc_bulk(mempool, ops_enq, burst_sz);


More information about the stable mailing list