[dpdk-stable] patch 'mem: fix storing old policy' has been queued to LTS release 18.11.1

Kevin Traynor ktraynor at redhat.com
Thu Jan 31 16:48:28 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/07/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From ea3ae1eefd27e5bc6111fc0aa1959bd189ebe97a Mon Sep 17 00:00:00 2001
From: Anatoly Burakov <anatoly.burakov at intel.com>
Date: Tue, 8 Jan 2019 16:46:28 +0000
Subject: [PATCH] mem: fix storing old policy

[ upstream commit ba07193e0343680ae5665efd45ecc41c0ec0059d ]

The original code was supposed to overwrite the value pointed to
by the pointer, but the new one is instead overwriting the
pointer value itself, which has no effect outside that function.
Fix it by adding a pointer dereference.

Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime")

Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
---
 lib/librte_eal/linuxapp/eal/eal_memalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
index 10b176d09..f63d9ca66 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
@@ -177,5 +177,5 @@ prepare_numa(int *oldpolicy, struct bitmask *oldmask, int socket_id)
 			"Failed to get current mempolicy: %s. "
 			"Assuming MPOL_DEFAULT.\n", strerror(errno));
-		oldpolicy = MPOL_DEFAULT;
+		*oldpolicy = MPOL_DEFAULT;
 	}
 	RTE_LOG(DEBUG, EAL,
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-31 15:44:06.217641017 +0000
+++ 0020-mem-fix-storing-old-policy.patch	2019-01-31 15:44:05.000000000 +0000
@@ -1,15 +1,16 @@
-From ba07193e0343680ae5665efd45ecc41c0ec0059d Mon Sep 17 00:00:00 2001
+From ea3ae1eefd27e5bc6111fc0aa1959bd189ebe97a Mon Sep 17 00:00:00 2001
 From: Anatoly Burakov <anatoly.burakov at intel.com>
 Date: Tue, 8 Jan 2019 16:46:28 +0000
 Subject: [PATCH] mem: fix storing old policy
 
+[ upstream commit ba07193e0343680ae5665efd45ecc41c0ec0059d ]
+
 The original code was supposed to overwrite the value pointed to
 by the pointer, but the new one is instead overwriting the
 pointer value itself, which has no effect outside that function.
 Fix it by adding a pointer dereference.
 
 Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime")
-Cc: stable at dpdk.org
 
 Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
 ---
@@ -17,7 +18,7 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
-index 5b421f1d7..b6fb183db 100644
+index 10b176d09..f63d9ca66 100644
 --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c
 +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
 @@ -177,5 +177,5 @@ prepare_numa(int *oldpolicy, struct bitmask *oldmask, int socket_id)


More information about the stable mailing list