[dpdk-stable] patch 'net/dpaa2: fix bad check for not-null' has been queued to LTS release 18.11.1

Kevin Traynor ktraynor at redhat.com
Thu Jan 31 16:48:53 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/07/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 25c6d79a6fce3c3220b88772acea76f93186e048 Mon Sep 17 00:00:00 2001
From: Hemant Agrawal <hemant.agrawal at nxp.com>
Date: Fri, 11 Jan 2019 12:24:16 +0000
Subject: [PATCH] net/dpaa2: fix bad check for not-null

[ upstream commit de2060055cf1184a4b724786a8d73e646a2f07a0 ]

The check !dpaa2->cscn is not correct to check non-null value.

Fixes: 5d9a1e4d23fe ("net/dpaa2: enhance queue memory cleanup")

Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index fa71807e6..8d4ea1bca 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -312,6 +312,5 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev)
 		for (i = 0; i < priv->nb_tx_queues; i++) {
 			dpaa2_q = (struct dpaa2_queue *)priv->tx_vq[i];
-			if (!dpaa2_q->cscn)
-				rte_free(dpaa2_q->cscn);
+			rte_free(dpaa2_q->cscn);
 		}
 		/*free memory for all queues (RX+TX) */
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-31 15:44:06.788127787 +0000
+++ 0045-net-dpaa2-fix-bad-check-for-not-null.patch	2019-01-31 15:44:05.000000000 +0000
@@ -1,12 +1,13 @@
-From de2060055cf1184a4b724786a8d73e646a2f07a0 Mon Sep 17 00:00:00 2001
+From 25c6d79a6fce3c3220b88772acea76f93186e048 Mon Sep 17 00:00:00 2001
 From: Hemant Agrawal <hemant.agrawal at nxp.com>
 Date: Fri, 11 Jan 2019 12:24:16 +0000
 Subject: [PATCH] net/dpaa2: fix bad check for not-null
 
+[ upstream commit de2060055cf1184a4b724786a8d73e646a2f07a0 ]
+
 The check !dpaa2->cscn is not correct to check non-null value.
 
 Fixes: 5d9a1e4d23fe ("net/dpaa2: enhance queue memory cleanup")
-Cc: stable at dpdk.org
 
 Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
 ---


More information about the stable mailing list