[dpdk-stable] [PATCH v2] telemetry: fix build warnings seen when using gcc 9

[Laatz, Kevin]

On 03/07/2019 10:23, Flavia Musatescu wrote:
> Suppress the unaligned packed member address warnings by extending
> the telemetry library build flags with -Wno-address-of-packed-member
> option, through the WERROR_FLAGS makefile variable.
>
> With this change additional warnings are turned on to be treated as errors,
> which causes the following build issues to be seen:
> - no previous prototype [-Werror=missing-prototypes]
> - initialization discards ‘const’ qualifier from pointer target type
>    [-Werror=discarded-qualifiers]
> - old-style function definition [-Werror=old-style-definition]
> - variable may be used before its value is set (when using icc compiler).
>
> Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats")
> Fixes: ee5ff0d3297e ("telemetry: add client feature and sockets")
> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> Fixes: 1b756087db93 ("telemetry: add parser for client socket messages")
> Fixes: fff6df7bf58e ("telemetry: fix using ports of different types")
> Fixes: 4080e46c8078 ("telemetry: support global metrics")
> Cc: stable at dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan at intel.com>
> Signed-off-by: Flavia Musatescu <flavia.musatescu at intel.com>
> ---
> Cc: ciara.power at intel.com
> Cc: bruce.richardson at intel.com
> Cc: reshma.pattan at intel.com
> ---
>   lib/librte_telemetry/Makefile                    |  2 +-
>   lib/librte_telemetry/meson.build                 |  2 +-
>   lib/librte_telemetry/rte_telemetry.c             | 19 ++++++------
>   lib/librte_telemetry/rte_telemetry_internal.h    |  4 +++
>   lib/librte_telemetry/rte_telemetry_parser.c      |  8 ++---
>   lib/librte_telemetry/rte_telemetry_parser_test.c | 27 ++++++++--------
>   lib/librte_telemetry/rte_telemetry_parser_test.h | 39 ------------------------
>   7 files changed, 33 insertions(+), 68 deletions(-)
>   delete mode 100644 lib/librte_telemetry/rte_telemetry_parser_test.h
>

LGTM, thanks!

Acked-by: Kevin Laatz <kevin.laatz at intel.com>