[dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg

OLoughlin, John john.oloughlin at intel.com
Thu Jul 11 17:33:33 CEST 2019


Hi Seán,

Thanks for that
I can confirm that the patch is functionally correct

Regards John

-----Original Message-----
From: Morrissey, Sean 
Sent: Thursday, July 11, 2019 3:40 PM
To: OLoughlin, John <john.oloughlin at intel.com>
Cc: Morrissey, Sean <sean.morrissey at intel.com>; ciara.power at intel.com; stable at dpdk.org
Subject: [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg

Added telemetry to EAL long options so that when --telemetry is passed as an EAL arg that there is no unrecognized argument error message printed.

Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
Cc: ciara.power at intel.com
Cc: stable at dpdk.org

Signed-off-by: Sean Morrissey <sean.morrissey at intel.com>
---
 lib/librte_eal/common/eal_common_options.c | 3 +++
 lib/librte_eal/common/eal_options.h        | 8 +++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 512d5088e..b7e511a63 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -80,6 +80,9 @@ eal_long_options[] = {
 	{OPT_VMWARE_TSC_MAP,    0, NULL, OPT_VMWARE_TSC_MAP_NUM   },
 	{OPT_LEGACY_MEM,        0, NULL, OPT_LEGACY_MEM_NUM       },
 	{OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
+#ifdef RTE_LIBRTE_TELEMETRY
+	{OPT_TELEMETRY,         0, NULL, OPT_TELEMETRY_NUM        },
+#endif
 	{OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
 	{0,                     0, NULL, 0                        }
 };
diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
index 9855429e5..f819845f5 100644
--- a/lib/librte_eal/common/eal_options.h
+++ b/lib/librte_eal/common/eal_options.h
@@ -67,9 +67,15 @@ enum {
 	OPT_SINGLE_FILE_SEGMENTS_NUM,
 #define OPT_IOVA_MODE          "iova-mode"
 	OPT_IOVA_MODE_NUM,
+
+#ifdef RTE_LIBRTE_TELEMETRY
+	#define OPT_TELEMETRY          "telemetry"
+		OPT_TELEMETRY_NUM,
+#endif
+
 #define OPT_MATCH_ALLOCATIONS  "match-allocations"
 	OPT_MATCH_ALLOCATIONS_NUM,
-	OPT_LONG_MAX_NUM
+	OPT_LONG_MAX_NUM,
 };
 
 extern const char eal_short_options[];
--
2.17.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.



More information about the stable mailing list