[dpdk-stable] patch 'app/testpmd: fix stdout flush after printing stats' has been queued to LTS release 17.11.7

Yongseok Koh yskoh at mellanox.com
Tue Jul 23 03:00:02 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 17.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objection by 07/27/19. So please
shout if anyone has objection.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Yongseok

---
>From 2d6a611d4fc6feda3b5285854a2bbf3b3f37cbfb Mon Sep 17 00:00:00 2001
From: Igor Romanov <igor.romanov at oktetlabs.ru>
Date: Mon, 18 Mar 2019 11:35:47 +0000
Subject: [PATCH] app/testpmd: fix stdout flush after printing stats

[ upstream commit 683d1e82a0f2caae1a9c6f1209ab4d743373a173 ]

User can specify stats period(n). The statistics should be available
to user every n second. But the print_stats() function does not
force stdout to be flushed, so for instance, a user reading testpmd's
stdout through pipe will not be able to read it until the stdout
buffer is filled.

Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")

Signed-off-by: Igor Romanov <igor.romanov at oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>
---
 app/test-pmd/testpmd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 2d9ca04df1..5db60c38e6 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2507,6 +2507,8 @@ print_stats(void)
 	printf("\nPort statistics ====================================");
 	for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++)
 		nic_stats_display(fwd_ports_ids[i]);
+
+	fflush(stdout);
 }
 
 static void
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-07-22 17:55:08.405446487 -0700
+++ 0035-app-testpmd-fix-stdout-flush-after-printing-stats.patch	2019-07-22 17:55:05.990469000 -0700
@@ -1,8 +1,10 @@
-From 683d1e82a0f2caae1a9c6f1209ab4d743373a173 Mon Sep 17 00:00:00 2001
+From 2d6a611d4fc6feda3b5285854a2bbf3b3f37cbfb Mon Sep 17 00:00:00 2001
 From: Igor Romanov <igor.romanov at oktetlabs.ru>
 Date: Mon, 18 Mar 2019 11:35:47 +0000
 Subject: [PATCH] app/testpmd: fix stdout flush after printing stats
 
+[ upstream commit 683d1e82a0f2caae1a9c6f1209ab4d743373a173 ]
+
 User can specify stats period(n). The statistics should be available
 to user every n second. But the print_stats() function does not
 force stdout to be flushed, so for instance, a user reading testpmd's
@@ -10,7 +12,6 @@
 buffer is filled.
 
 Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
-Cc: stable at dpdk.org
 
 Signed-off-by: Igor Romanov <igor.romanov at oktetlabs.ru>
 Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
@@ -20,10 +21,10 @@
  1 file changed, 2 insertions(+)
 
 diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
-index d9d0c16d4c..216be47f92 100644
+index 2d9ca04df1..5db60c38e6 100644
 --- a/app/test-pmd/testpmd.c
 +++ b/app/test-pmd/testpmd.c
-@@ -3046,6 +3046,8 @@ print_stats(void)
+@@ -2507,6 +2507,8 @@ print_stats(void)
  	printf("\nPort statistics ====================================");
  	for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++)
  		nic_stats_display(fwd_ports_ids[i]);


More information about the stable mailing list