[dpdk-stable] patch 'build: fix crash by disabling AVX512 with binutils 2.31' has been queued to LTS release 17.11.7

[Yongseok Koh]

Hi,

FYI, your patch has been queued to LTS release 17.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objection by 07/27/19. So please
shout if anyone has objection.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Yongseok

---
>From d530adaf7034ff370a96310ffa1481f1bdc81e2b Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at intel.com>
Date: Thu, 2 May 2019 14:35:26 +0100
Subject: [PATCH] build: fix crash by disabling AVX512 with binutils 2.31

[ backported from upstream commit e19c6de3f2f12d0f49bdf9e787b3f43612c1df3c ]

On Skylake platform, with native build, KNI kernel module crashes
because of the corrupted values passed to kernel module.

The corruption occurs because the userspace kni library works
unexpectedly. Compiler [1] is using AVX512 instructions and generated
binary is wrong [2].

It turned around gcc does its job correct, but gas is generating binary
wrong. And expected binutils 2.30, 2.31 & 2.31.1 are affected. Issue has
been fixed in binutils 2.32 with:
Commit x86: don't mistakenly scale non-8-bit displacements

AVX512 was already disabled with bintuils 2.30 [3], extending it to
2.31 & 2.31.1 too.

[1] gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)

[2] gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028

[3] Bugzilla ID 97 has the details.

Bugzilla ID: 249

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 mk/toolchain/gcc/rte.toolchain-compat.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index 1828e7947b..64f0cbc6b9 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -54,7 +54,14 @@ ifneq ($(filter 2.30%,$(LD_VERSION)),)
 FORCE_DISABLE_AVX512 := y
 # print warning only once for librte_eal
 ifneq ($(filter %librte_eal,$(CURDIR)),)
-$(warning AVX512 support disabled because of ld 2.30. See Bug 97)
+$(warning AVX512 support disabled because of binutils 2.30. See Bug 97)
+endif
+endif
+ifneq ($(filter 2.31%,$(LD_VERSION)),)
+FORCE_DISABLE_AVX512 := y
+# print warning only once for librte_eal
+ifneq ($(filter %librte_eal,$(CURDIR)),)
+$(warning AVX512 support disabled because of binutils 2.31. See Bug 249)
 endif
 endif
 endif
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-07-22 17:55:11.431900831 -0700
+++ 0092-build-fix-crash-by-disabling-AVX512-with-binutils-2..patch	2019-07-22 17:55:06.440477000 -0700
@@ -1,8 +1,10 @@
-From e19c6de3f2f12d0f49bdf9e787b3f43612c1df3c Mon Sep 17 00:00:00 2001
+From d530adaf7034ff370a96310ffa1481f1bdc81e2b Mon Sep 17 00:00:00 2001
 From: Ferruh Yigit <ferruh.yigit at intel.com>
 Date: Thu, 2 May 2019 14:35:26 +0100
 Subject: [PATCH] build: fix crash by disabling AVX512 with binutils 2.31
 
+[ backported from upstream commit e19c6de3f2f12d0f49bdf9e787b3f43612c1df3c ]
+
 On Skylake platform, with native build, KNI kernel module crashes
 because of the corrupted values passed to kernel module.
 
@@ -25,53 +27,18 @@
 [3] Bugzilla ID 97 has the details.
 
 Bugzilla ID: 249
-Cc: stable at dpdk.org
 
 Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
 Acked-by: Bruce Richardson <bruce.richardson at intel.com>
 ---
- config/x86/meson.build                   | 4 ++++
- doc/guides/rel_notes/release_19_05.rst   | 6 ++++++
  mk/toolchain/gcc/rte.toolchain-compat.mk | 9 ++++++++-
- 3 files changed, 18 insertions(+), 1 deletion(-)
+ 1 file changed, 8 insertions(+), 1 deletion(-)
 
-diff --git a/config/x86/meson.build b/config/x86/meson.build
-index ca4d12506a..0a7bed75e2 100644
---- a/config/x86/meson.build
-+++ b/config/x86/meson.build
-@@ -10,6 +10,10 @@ if not is_windows
- 			message('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97')
- 		endif
- 	endif
-+	if ldver.contains('2.31') and cc.has_argument('-mno-avx512f')
-+		machine_args += '-mno-avx512f'
-+		message('Binutils 2.31 detected, disabling AVX512 support as workaround for bug #249')
-+	endif
- endif
- 
- # we require SSE4.2 for DPDK
-diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst
-index 439725c8aa..468e325395 100644
---- a/doc/guides/rel_notes/release_19_05.rst
-+++ b/doc/guides/rel_notes/release_19_05.rst
-@@ -368,6 +368,12 @@ Known Issues
-    Also, make sure to start the actual text at the margin.
-    =========================================================
- 
-+* **On x86 platforms, AVX512 support is disabled with binutils 2.31**
-+
-+  Because a defect in binutils 2.31 AVX512 support is disabled.
-+  DPDK defect: https://bugs.dpdk.org/show_bug.cgi?id=249
-+  GCC defect: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028
-+
- * **No software AES-XTS implementation.**
- 
-   There are currently no cryptodev software PMDs available which implement
 diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
-index df71e4a8b5..ea40a11c0c 100644
+index 1828e7947b..64f0cbc6b9 100644
 --- a/mk/toolchain/gcc/rte.toolchain-compat.mk
 +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
-@@ -27,7 +27,14 @@ ifneq ($(filter 2.30%,$(LD_VERSION)),)
+@@ -54,7 +54,14 @@ ifneq ($(filter 2.30%,$(LD_VERSION)),)
  FORCE_DISABLE_AVX512 := y
  # print warning only once for librte_eal
  ifneq ($(filter %librte_eal,$(CURDIR)),)