[dpdk-stable] patch 'net/ring: fix return value check' has been queued to LTS release 17.11.7

Yongseok Koh yskoh at mellanox.com
Tue Jul 23 03:01:05 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 17.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objection by 07/27/19. So please
shout if anyone has objection.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Yongseok

---
>From 7989f05f3498ecd1d33ca2fcdf6389efa3b660d5 Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at intel.com>
Date: Tue, 23 Apr 2019 16:23:32 +0100
Subject: [PATCH] net/ring: fix return value check

[ upstream commit e0474b94f8a36672d66be7408e3f7cf00e302329 ]

'rte_eth_dev_get_port_by_name()' return value is not checked caught by
coverity, adding return value check.

Coverity issue: 305853
Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API")

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 drivers/net/ring/rte_eth_ring.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index da165152a6..c56dc339d5 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -413,7 +413,11 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
 		return -1;
 	}
 
-	rte_eth_dev_get_port_by_name(ring_name, &port_id);
+	ret = rte_eth_dev_get_port_by_name(ring_name, &port_id);
+	if (ret) {
+		rte_errno = ENODEV;
+		return -1;
+	}
 
 	return port_id;
 }
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-07-22 17:55:11.762257794 -0700
+++ 0098-net-ring-fix-return-value-check.patch	2019-07-22 17:55:06.476479000 -0700
@@ -1,14 +1,15 @@
-From e0474b94f8a36672d66be7408e3f7cf00e302329 Mon Sep 17 00:00:00 2001
+From 7989f05f3498ecd1d33ca2fcdf6389efa3b660d5 Mon Sep 17 00:00:00 2001
 From: Ferruh Yigit <ferruh.yigit at intel.com>
 Date: Tue, 23 Apr 2019 16:23:32 +0100
 Subject: [PATCH] net/ring: fix return value check
 
+[ upstream commit e0474b94f8a36672d66be7408e3f7cf00e302329 ]
+
 'rte_eth_dev_get_port_by_name()' return value is not checked caught by
 coverity, adding return value check.
 
 Coverity issue: 305853
 Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API")
-Cc: stable at dpdk.org
 
 Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
 Acked-by: Bruce Richardson <bruce.richardson at intel.com>
@@ -17,10 +18,10 @@
  1 file changed, 5 insertions(+), 1 deletion(-)
 
 diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
-index 979993fd3e..ab963a03c4 100644
+index da165152a6..c56dc339d5 100644
 --- a/drivers/net/ring/rte_eth_ring.c
 +++ b/drivers/net/ring/rte_eth_ring.c
-@@ -396,7 +396,11 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
+@@ -413,7 +413,11 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
  		return -1;
  	}
  


More information about the stable mailing list