[dpdk-stable] [PATCH 5/8] net/kni: do not count unsent packets as errors
David Marchand
david.marchand at redhat.com
Thu Jul 25 21:07:17 CEST 2019
On Thu, Jul 25, 2019 at 6:12 PM Ferruh Yigit <ferruh.yigit at intel.com> wrote:
>
> On 7/25/2019 10:14 AM, David Marchand wrote:
> > err_pkts reflects the number of packets that the driver did not manage to
> > send.
> > This is a temporary situation, those packets are not freed and the
> > application can still retry to send them later.
> > Hence, we can't count them as transmit failed.
>
> 'err_pkts' seems calculated wrong both in Rx & Tx and KNI PMD, looks like we can
> remove it completely, what do you think?
On the rx side, I agree that err_pkts makes little sense.
On the tx side, it can be seen as a "tx full" counter.
So not sure about the tx side, but I sure can remove the rx part (in a
separate patch?).
--
David Marchand
More information about the stable
mailing list