[dpdk-stable] [dpdk-dev] [PATCH v4] examples/l3fwd: fix unaligned memory access

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Bruce Richardson
> Sent: Tuesday, July 30, 2019 3:17 PM
> To: Thomas Monjalon <thomas at monjalon.net>
> Cc: dev at dpdk.org; stable at dpdk.org; hgovindh
> <hariprasad.govindharajan at intel.com>; Marko Kovacevic
> <marko.kovacevic at intel.com>; Ori Kam <orika at mellanox.com>; Pablo de Lara
> <pablo.de.lara.guarch at intel.com>; Radu Nicolau <radu.nicolau at intel.com>;
> Akhil Goyal <akhil.goyal at nxp.com>; Tomasz Kantecki
> <tomasz.kantecki at intel.com>; drc at linux.vnet.ibm.com;
> ruifeng.wang at arm.com; maciej.czekaj at caviumnetworks.com
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] examples/l3fwd: fix unaligned
> memory access
> 
> On Tue, Jul 30, 2019 at 10:50:14AM +0200, Thomas Monjalon wrote:
> > Review please?
> >
> > 26/07/2019 15:58, hgovindh:
> > > Fix unaligned memory access when reading IPv6 header which leads to
> > > segmentation fault by changing aligned memory read to unaligned
> > > memory read.
> > >
> > > Bugzilla ID: 279
> > > Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build")
> > > Cc: maciej.czekaj at caviumnetworks.com
> > > Cc: stable at dpdk.org
> > > Signed-off-by: hgovindh <hariprasad.govindharajan at intel.com>
> > > --- a/examples/l3fwd/l3fwd_em.c
> > > +++ b/examples/l3fwd/l3fwd_em.c
> > > +#if defined RTE_ARCH_X86
> > > +	key.xmm[1] = _mm_loadu_si128(data1); #else
> > >  	key.xmm[1] = *(xmm_t *)data1;
> > > -
> > > +#endif
> >
> 
> The blank line should be re-added below the #ifdef. Apart from that the fix looks
> correct to me.
> 
> Reviewed-by: Bruce Richardson <bruce.richardson at intel.com>
Reviewed-by: Jerin Jacob <jerinj at marvell.com>