[dpdk-stable] patch 'examples/qos_sched: do not dereference global config struct' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Fri Jun 21 18:46:04 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/26/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/54c7559ddb79371772ec173f233fea6a6204dc98

Thanks.

Kevin Traynor

---
>From 54c7559ddb79371772ec173f233fea6a6204dc98 Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Wed, 15 May 2019 09:54:22 +0200
Subject: [PATCH] examples/qos_sched: do not dereference global config struct

[ upstream commit 4df7d46bbdba4f390816476fa62f21668f87b995 ]

Prefer the existing apis rather than direct access the configuration
structure.

Fixes: de3cfa2c9823 ("sched: initial import")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
 examples/qos_sched/args.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
index 83eee95cc..7431b2981 100644
--- a/examples/qos_sched/args.c
+++ b/examples/qos_sched/args.c
@@ -91,14 +91,13 @@ static uint64_t
 app_eal_core_mask(void)
 {
-	uint32_t i;
 	uint64_t cm = 0;
-	struct rte_config *cfg = rte_eal_get_configuration();
+	uint32_t i;
 
 	for (i = 0; i < APP_MAX_LCORE; i++) {
-		if (cfg->lcore_role[i] == ROLE_RTE)
+		if (rte_lcore_has_role(i, ROLE_RTE))
 			cm |= (1ULL << i);
 	}
 
-	cm |= (1ULL << cfg->master_lcore);
+	cm |= (1ULL << rte_get_master_lcore());
 
 	return cm;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-06-21 17:22:12.792821906 +0100
+++ 0020-examples-qos_sched-do-not-dereference-global-config-.patch	2019-06-21 17:22:11.731518943 +0100
@@ -1 +1 @@
-From 4df7d46bbdba4f390816476fa62f21668f87b995 Mon Sep 17 00:00:00 2001
+From 54c7559ddb79371772ec173f233fea6a6204dc98 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 4df7d46bbdba4f390816476fa62f21668f87b995 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list