[dpdk-stable] patch 'net/bnx2x: fix link state' has been queued to LTS release 18.11.3

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/27/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/882f29f8e119e874eebb03b93183136953405643

Thanks.

Kevin Traynor

---
>From 882f29f8e119e874eebb03b93183136953405643 Mon Sep 17 00:00:00 2001
From: Shahed Shaikh <shshaikh at marvell.com>
Date: Tue, 4 Jun 2019 11:53:51 -0700
Subject: [PATCH] net/bnx2x: fix link state

[ upstream commit 6c5b9b2aaf3945638af8acba00048b0454355d51 ]

Don't call bnx2x_link_status_update() from bnx2x_link_update().
Actual use case of bnx2x_link_status_update() is to update the link
status in shared memory between driver and MFW, and not to get the
link status from HW.

So ideally, bnx2x_link_status_update() should be called when there
is an actual link event or change in link status.

Calling bnx2x_link_status_update() from bnx2x_link_update() may
corrupt the data of link status in shared memory and result
in inconsistent state of link.

Fixes: 540a211084a7 ("bnx2x: driver core")

Signed-off-by: Shahed Shaikh <shshaikh at marvell.com>
Acked-by: Rasesh Mody <rmody at marvell.com>
---
 drivers/net/bnx2x/bnx2x_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
index c23f4b1a6..7c440d33e 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.c
+++ b/drivers/net/bnx2x/bnx2x_ethdev.c
@@ -88,5 +88,4 @@ bnx2x_link_update(struct rte_eth_dev *dev)
 	PMD_INIT_FUNC_TRACE(sc);
 
-	bnx2x_link_status_update(sc);
 	memset(&link, 0, sizeof(link));
 	mb();
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-06-24 16:18:56.300466549 +0100
+++ 0023-net-bnx2x-fix-link-state.patch	2019-06-24 16:18:55.033431176 +0100
@@ -1 +1 @@
-From 6c5b9b2aaf3945638af8acba00048b0454355d51 Mon Sep 17 00:00:00 2001
+From 882f29f8e119e874eebb03b93183136953405643 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6c5b9b2aaf3945638af8acba00048b0454355d51 ]
+
@@ -19 +20,0 @@
-Cc: stable at dpdk.org
@@ -28 +29 @@
-index 11a20e210..7429004de 100644
+index c23f4b1a6..7c440d33e 100644
@@ -31 +32 @@
-@@ -89,5 +89,4 @@ bnx2x_link_update(struct rte_eth_dev *dev)
+@@ -88,5 +88,4 @@ bnx2x_link_update(struct rte_eth_dev *dev)