[dpdk-stable] [PATCH 1/2] test/rcu: increase the size of num cores variable
Honnappa Nagarahalli
honnappa.nagarahalli at arm.com
Fri Jun 28 05:44:05 CEST 2019
num_cores is of type uint8_t. This results in the following
compilation error.
test_rcu_qsbr_perf.c:649:16: error: comparison is always false
due to limited range of data type [-Werror=type-limits]
if (num_cores >= RTE_MAX_LCORE) {
^~
RTE_MAX_LCORE is set to 256 for armv8 config.
Fixes: e6a14121f4ae ("test/rcu: remove arbitrary limit on max core count")
Cc: stable at dpdk.org
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
---
app/test/test_rcu_qsbr.c | 4 ++--
app/test/test_rcu_qsbr_perf.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c
index 943a1e370..0c6267ee9 100644
--- a/app/test/test_rcu_qsbr.c
+++ b/app/test/test_rcu_qsbr.c
@@ -27,7 +27,7 @@
#define TEST_RCU_QSBR_CNT_INIT 1
uint16_t enabled_core_ids[RTE_MAX_LCORE];
-uint8_t num_cores;
+uint16_t num_cores;
static uint32_t *keys;
#define TOTAL_ENTRY (1024 * 8)
@@ -891,7 +891,7 @@ static int
test_rcu_qsbr_mw_mv_mqs(void)
{
int i, j;
- uint8_t test_cores;
+ uint16_t test_cores;
writer_done = 0;
test_cores = num_cores / 4;
diff --git a/app/test/test_rcu_qsbr_perf.c b/app/test/test_rcu_qsbr_perf.c
index 363365f46..b1a910423 100644
--- a/app/test/test_rcu_qsbr_perf.c
+++ b/app/test/test_rcu_qsbr_perf.c
@@ -17,7 +17,7 @@
/* Check condition and return an error if true. */
static uint16_t enabled_core_ids[RTE_MAX_LCORE];
-static uint8_t num_cores;
+static uint16_t num_cores;
static uint32_t *keys;
#define TOTAL_ENTRY (1024 * 8)
--
2.17.1
More information about the stable
mailing list