[dpdk-stable] [dpdk-dev] [PATCH] drivers/net: fix shifting 32-bit signed variable 31 times

Ferruh Yigit ferruh.yigit at intel.com
Fri Mar 1 18:18:25 CET 2019


On 2/26/2019 10:31 AM, Ferruh Yigit wrote:
> On 2/19/2019 1:24 PM, Andrius Sirvys wrote:
>> Shifting signed 32-bit values by 31-bits has the potential for
>> unexpected  outcomes as compiler can overwrite a bit.
>> Specified that values are unsigned.
>>
>> Errors are observed from running cppcheck.
>>
>> Bugzilla ID: 58
>> Fixes: 69e209be5464 ("net/axgbe: add register map and related macros")
>> Fixes: b5bf7719221d ("bnx2x: driver support routines")
>> Fixes: ed2ced6fe927 ("net/bnxt: check initialization before accessing stats")
>> Fixes: 6fda3f0ddda9 ("net/cxgbe: add API to program hardware MPS table")
>> Fixes: bdb244b96920 ("e1000: whitespace changes")
>> Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
>> Fixes: 2fe669f4bcd2 ("net/nfp: support MAC address change")
>> Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
>> Fixes: ec94dbc57362 ("qede: add base driver")
>> Fixes: d2e7d931d0ad ("net/qede/base: formatting changes")
>> Fixes: cdc07e83bb24 ("net/tap: add eBPF program file")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Andrius Sirvys <andrius.sirvys at intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
>
Applied to dpdk-next-net/master, thanks.


More information about the stable mailing list