[dpdk-stable] [PATCH v2] test/distributor: fix sprintf with strlcpy
Hunt, David
david.hunt at intel.com
Mon Mar 25 16:11:29 CET 2019
Hi Poornima,
On 14/2/2019 9:45 AM, Pallantla Poornima wrote:
> sprintf function is not secure as it doesn't check the length of string.
> replaced sprintf with strlcpy.
>
> Fixes: f74df2c57e ("test/distributor: test single and burst API")
> Cc: stable at dpdk.org
>
> Signed-off-by: Pallantla Poornima <pallantlax.poornima at intel.com>
> ---
> v2: Addressed review comment to replace snprintf to strlcpy.
> ---
>
> test/test/test_distributor.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c
> index 98919ec0c..da3348fd1 100644
> --- a/test/test/test_distributor.c
> +++ b/test/test/test_distributor.c
> @@ -11,6 +11,7 @@
> #include <rte_mempool.h>
> #include <rte_mbuf.h>
> #include <rte_distributor.h>
> +#include <rte_string_fns.h>
>
> #define ITER_POWER 20 /* log 2 of how many iterations we do when timing. */
> #define BURST 32
> @@ -642,9 +643,11 @@ test_distributor(void)
>
> worker_params.dist = dist[i];
> if (i)
> - sprintf(worker_params.name, "burst");
> + strlcpy(worker_params.name, "burst",
> + sizeof(worker_params.name));
> else
> - sprintf(worker_params.name, "single");
> + strlcpy(worker_params.name, "single",
> + sizeof(worker_params.name));
>
> rte_eal_mp_remote_launch(handle_work,
> &worker_params, SKIP_MASTER);
Acked-by: David Hunt <david.hunt at intel.com>
More information about the stable
mailing list