[dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection

[Thomas Monjalon]

10/04/2019 09:29, Pavan Nikhilesh Bhagavatula:
> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
> 
> Currently, l3wfd em mode has two datapath modes em_sequential and
> em_hlm. We can select either of them by defining NO_HASH_MULTI_LOOKUP to
> one or zero.
> The code checks if NO_HASH_MULTI_LOOKUP is defined or not instead of
> checking for the value.
> 
> Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
> ---
> --- a/examples/l3fwd/l3fwd_em.c
> +++ b/examples/l3fwd/l3fwd_em.c
>  #if defined RTE_ARCH_X86 || defined RTE_MACHINE_CPUFLAG_NEON
> -#if defined(NO_HASH_MULTI_LOOKUP)
> +#if NO_HASH_MULTI_LOOKUP

It does not compile:

examples/l3fwd/l3fwd_em.c:302:5: error:
	'NO_HASH_MULTI_LOOKUP' is not defined, evaluates to 0 [-Werror,-Wundef]
	#if NO_HASH_MULTI_LOOKUP

Anyway such compilation option should be just removed.
Please replace it with a runtime option and/or make it documented.
Thanks