[dpdk-stable] patch 'examples/power: fix string overflow' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Wed May 8 12:15:14 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/13/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/45790bfbd3c2ed64596e25fea9b3229a5ad096ab

Thanks.

Kevin Traynor

---
>From 45790bfbd3c2ed64596e25fea9b3229a5ad096ab Mon Sep 17 00:00:00 2001
From: Reshma Pattan <reshma.pattan at intel.com>
Date: Wed, 10 Apr 2019 15:54:31 +0100
Subject: [PATCH] examples/power: fix string overflow

[ upstream commit 57fad3e25fee6400af07a917e876ef8e4ee0e653 ]

Use strlcpy instead of strcpy to fix string overflow.

Coverity issue: 337671
Fixes: a63504a90f ("examples/power: add JSON string handling")

Signed-off-by: Reshma Pattan <reshma.pattan at intel.com>
Acked-by: David Hunt <david.hunt at intel.com>
---
 examples/vm_power_manager/channel_monitor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
index d45d8f74b..954bdf787 100644
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -159,5 +159,6 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
 				return ret;
 		} else if (!strcmp(key, "name")) {
-			strcpy(pkt->vm_name, json_string_value(value));
+			strlcpy(pkt->vm_name, json_string_value(value),
+					sizeof(pkt->vm_name));
 		} else if (!strcmp(key, "command")) {
 			char command[32];
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-08 11:05:07.428019816 +0100
+++ 0032-examples-power-fix-string-overflow.patch	2019-05-08 11:05:05.815933054 +0100
@@ -1 +1 @@
-From 57fad3e25fee6400af07a917e876ef8e4ee0e653 Mon Sep 17 00:00:00 2001
+From 45790bfbd3c2ed64596e25fea9b3229a5ad096ab Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 57fad3e25fee6400af07a917e876ef8e4ee0e653 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index bc5679d4b..971e4f2bc 100644
+index d45d8f74b..954bdf787 100644
@@ -22 +23 @@
-@@ -160,5 +160,6 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
+@@ -159,5 +159,6 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)


More information about the stable mailing list