[dpdk-stable] patch 'raw/dpaa2_cmdif: fix warnings with GCC 9' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Wed May 8 12:15:31 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/13/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/4a1b3238788869011c4212c3d27c2d7dac771874

Thanks.

Kevin Traynor

---
>From 4a1b3238788869011c4212c3d27c2d7dac771874 Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Wed, 1 May 2019 20:50:14 +0100
Subject: [PATCH] raw/dpaa2_cmdif: fix warnings with GCC 9

[ upstream commit a53f14f96112a0851a9c3788dd1e7b9d61c50191 ]

GCC9 gives warnings if the parameter passed to printf for "%s" could be
NULL, so we need to add checks in some cases to ensure that is not the
case.

Fixes: 3298fa4853b8 ("raw/dpaa2_cmdif: introduce DPAA2 command interface driver")

Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
---
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
index 469960a3e..11951980f 100644
--- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
@@ -275,4 +275,6 @@ dpaa2_cmdif_remove(struct rte_vdev_device *vdev)
 
 	name = rte_vdev_device_name(vdev);
+	if (name == NULL)
+		return -1;
 
 	DPAA2_CMDIF_INFO("Closing %s on NUMA node %d", name, rte_socket_id());
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-08 11:05:08.244935731 +0100
+++ 0049-raw-dpaa2_cmdif-fix-warnings-with-GCC-9.patch	2019-05-08 11:05:05.859932134 +0100
@@ -1 +1 @@
-From a53f14f96112a0851a9c3788dd1e7b9d61c50191 Mon Sep 17 00:00:00 2001
+From 4a1b3238788869011c4212c3d27c2d7dac771874 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a53f14f96112a0851a9c3788dd1e7b9d61c50191 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 7d311b2ee..da3c7d7a6 100644
+index 469960a3e..11951980f 100644
@@ -22 +23 @@
-@@ -271,4 +271,6 @@ dpaa2_cmdif_remove(struct rte_vdev_device *vdev)
+@@ -275,4 +275,6 @@ dpaa2_cmdif_remove(struct rte_vdev_device *vdev)


More information about the stable mailing list