[dpdk-stable] patch 'examples/power: fix buffer overrun' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Wed May 8 18:02:03 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/14/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/695d45d68113f1a5ae3a18b3842fac329c3a7d69

Thanks.

Kevin Traynor

---
>From 695d45d68113f1a5ae3a18b3842fac329c3a7d69 Mon Sep 17 00:00:00 2001
From: David Hunt <david.hunt at intel.com>
Date: Fri, 26 Apr 2019 09:42:09 +0100
Subject: [PATCH] examples/power: fix buffer overrun

[ upstream commit 3f1fc5f2cbc57ed719f9a1b24c8e450c5a95e8db ]

The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements,
yet the code can attempt to look at the index at  RTE_MAX_LCORE,
which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to
RTE_MAX_LCORE_FREQS.

Coverity issue: 337660
Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host")

Signed-off-by: David Hunt <david.hunt at intel.com>
Acked-by: Reshma Pattan <reshma.pattan at intel.com>
---
 examples/vm_power_manager/power_manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/vm_power_manager/power_manager.c b/examples/vm_power_manager/power_manager.c
index f9e8c0abd..318fb0255 100644
--- a/examples/vm_power_manager/power_manager.c
+++ b/examples/vm_power_manager/power_manager.c
@@ -158,5 +158,5 @@ power_manager_get_current_frequency(unsigned core_num)
 	index = rte_power_get_freq(core_num);
 	rte_spinlock_unlock(&global_core_freq_info[core_num].power_sl);
-	if (index >= POWER_MGR_MAX_CPUS)
+	if (index >= RTE_MAX_LCORE_FREQS)
 		freq = 0;
 	else
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-08 16:33:57.808861123 +0100
+++ 0006-examples-power-fix-buffer-overrun.patch	2019-05-08 16:33:57.360579813 +0100
@@ -1 +1 @@
-From 3f1fc5f2cbc57ed719f9a1b24c8e450c5a95e8db Mon Sep 17 00:00:00 2001
+From 695d45d68113f1a5ae3a18b3842fac329c3a7d69 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 3f1fc5f2cbc57ed719f9a1b24c8e450c5a95e8db ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 9553455be..9d4e587b0 100644
+index f9e8c0abd..318fb0255 100644
@@ -25 +26 @@
-@@ -144,5 +144,5 @@ power_manager_get_current_frequency(unsigned core_num)
+@@ -158,5 +158,5 @@ power_manager_get_current_frequency(unsigned core_num)
@@ -28 +29 @@
--	if (index >= RTE_MAX_LCORE)
+-	if (index >= POWER_MGR_MAX_CPUS)


More information about the stable mailing list