[dpdk-stable] patch 'net/tap: fix memory leak on IPC request' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Wed May 8 18:02:07 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/14/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/8f3e73d8c22ca3ace05b6d82482f6258f0b089b8

Thanks.

Kevin Traynor

---
>From 8f3e73d8c22ca3ace05b6d82482f6258f0b089b8 Mon Sep 17 00:00:00 2001
From: Herakliusz Lipiec <herakliusz.lipiec at intel.com>
Date: Thu, 25 Apr 2019 13:48:17 +0100
Subject: [PATCH] net/tap: fix memory leak on IPC request

[ upstream commit 388e061ecfe42446d51d8a90dabce6b43fd76167 ]

When sending synchronous IPC requests, the caller must free the response
buffer if the request was successful and reply is no longer needed.
Fix the code to correctly
use the IPC API.

Bugzilla ID: 228
Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")

Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec at intel.com>
Acked-by: Keith Wiles <keith.wiles at intel.com>
---
 drivers/net/tap/rte_eth_tap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 551f4d3a2..292657d0b 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2089,5 +2089,5 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)
 	for (queue = 0; queue < reply_param->txq_count; queue++)
 		process_private->txq_fds[queue] = reply->fds[fd_iterator++];
-
+	free(reply);
 	return 0;
 }
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-08 16:33:57.999655182 +0100
+++ 0010-net-tap-fix-memory-leak-on-IPC-request.patch	2019-05-08 16:33:57.365579654 +0100
@@ -1 +1 @@
-From 388e061ecfe42446d51d8a90dabce6b43fd76167 Mon Sep 17 00:00:00 2001
+From 8f3e73d8c22ca3ace05b6d82482f6258f0b089b8 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 388e061ecfe42446d51d8a90dabce6b43fd76167 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 7f74b5dc9..f8a4169c5 100644
+index 551f4d3a2..292657d0b 100644
@@ -25 +26 @@
-@@ -2119,5 +2119,5 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)
+@@ -2089,5 +2089,5 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)


More information about the stable mailing list