[dpdk-stable] patch 'net/kni: fix return value check' has been queued to LTS release 18.11.2

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/14/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/3ec50060a725b0899626eabd9f2512b28471c79a

Thanks.

Kevin Traynor

---
>From 3ec50060a725b0899626eabd9f2512b28471c79a Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at intel.com>
Date: Tue, 23 Apr 2019 16:36:21 +0100
Subject: [PATCH] net/kni: fix return value check

[ upstream commit 994e039b953b06a385d4362e1729a150f1a02d77 ]

'rte_kni_release()' return value is not checked, adding it.

Coverity issue: 336837
Fixes: 75e2bc54c018 ("net/kni: add KNI PMD")

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 drivers/net/kni/rte_eth_kni.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c
index a1e9970df..9879985ec 100644
--- a/drivers/net/kni/rte_eth_kni.c
+++ b/drivers/net/kni/rte_eth_kni.c
@@ -455,4 +455,5 @@ eth_kni_remove(struct rte_vdev_device *vdev)
 	struct pmd_internals *internals;
 	const char *name;
+	int ret;
 
 	name = rte_vdev_device_name(vdev);
@@ -473,5 +474,7 @@ eth_kni_remove(struct rte_vdev_device *vdev)
 
 	internals = eth_dev->data->dev_private;
-	rte_kni_release(internals->kni);
+	ret = rte_kni_release(internals->kni);
+	if (ret)
+		PMD_LOG(WARNING, "Not able to release kni for %s", name);
 
 	rte_eth_dev_release_port(eth_dev);
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-08 16:33:58.620227926 +0100
+++ 0023-net-kni-fix-return-value-check.patch	2019-05-08 16:33:57.396578668 +0100
@@ -1 +1 @@
-From 994e039b953b06a385d4362e1729a150f1a02d77 Mon Sep 17 00:00:00 2001
+From 3ec50060a725b0899626eabd9f2512b28471c79a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 994e039b953b06a385d4362e1729a150f1a02d77 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index 89f44737c..1f232e4da 100644
+index a1e9970df..9879985ec 100644
@@ -21 +22 @@
-@@ -460,4 +460,5 @@ eth_kni_remove(struct rte_vdev_device *vdev)
+@@ -455,4 +455,5 @@ eth_kni_remove(struct rte_vdev_device *vdev)
@@ -27 +28 @@
-@@ -478,5 +479,7 @@ eth_kni_remove(struct rte_vdev_device *vdev)
+@@ -473,5 +474,7 @@ eth_kni_remove(struct rte_vdev_device *vdev)