[dpdk-stable] patch 'test/barrier: fix for Power CPUs' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Tue May 14 16:43:55 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/20/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/73fcd00b3a697668fe203a178d65e7029380c67b

Thanks.

Kevin Traynor

---
>From 73fcd00b3a697668fe203a178d65e7029380c67b Mon Sep 17 00:00:00 2001
From: David Christensen <drc at linux.vnet.ibm.com>
Date: Wed, 8 May 2019 16:02:43 -0500
Subject: [PATCH] test/barrier: fix for Power CPUs

[ upstream commit 2d119c3baac4409092d064d386deb33d8f61f90f ]

The memory barrier test fails on IBM Power 9 systems.  Add additional
barriers to accommodate the weakly ordered model used on Power CPUs.

Fixes: 93da5b59afc9 ("test: introduce memory barrier test case")

Signed-off-by: David Christensen <drc at linux.vnet.ibm.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
---
 test/test/test_barrier.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/test/test_barrier.c b/test/test/test_barrier.c
index ae37b1e5c..92f3d325f 100644
--- a/test/test/test_barrier.c
+++ b/test/test/test_barrier.c
@@ -93,4 +93,5 @@ plock_lock(struct plock *l, uint32_t self)
 
 	l->flag[self] = 1;
+	rte_smp_wmb();
 	l->victim = self;
 
@@ -99,4 +100,5 @@ plock_lock(struct plock *l, uint32_t self)
 	while (l->flag[other] == 1 && l->victim == self)
 		rte_pause();
+	rte_smp_rmb();
 }
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-14 15:39:07.838812101 +0100
+++ 0011-test-barrier-fix-for-Power-CPUs.patch	2019-05-14 15:39:07.307558931 +0100
@@ -1 +1 @@
-From 2d119c3baac4409092d064d386deb33d8f61f90f Mon Sep 17 00:00:00 2001
+From 73fcd00b3a697668fe203a178d65e7029380c67b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 2d119c3baac4409092d064d386deb33d8f61f90f ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -15 +16 @@
- app/test/test_barrier.c | 2 ++
+ test/test/test_barrier.c | 2 ++
@@ -18,4 +19,4 @@
-diff --git a/app/test/test_barrier.c b/app/test/test_barrier.c
-index a0b47042f..43b5f6232 100644
---- a/app/test/test_barrier.c
-+++ b/app/test/test_barrier.c
+diff --git a/test/test/test_barrier.c b/test/test/test_barrier.c
+index ae37b1e5c..92f3d325f 100644
+--- a/test/test/test_barrier.c
++++ b/test/test/test_barrier.c


More information about the stable mailing list