[dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range

Stephen Hemminger stephen at networkplumber.org
Fri Nov 8 04:24:29 CET 2019


On Thu, 7 Nov 2019 21:52:47 +0100
David Marchand <david.marchand at redhat.com> wrote:

> Stephen,
> 
> Do we want to fix testpmd?
> 
> $ git grep 192.*18 origin/master -- app/test-pmd/
> origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U <<
> 24) | (18 << 16) | (0 << 8) | 1;
> origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr = (192U <<
> 24) | (18 << 16) | (0 << 8) | 2;
> 
> Commit bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")
> 

Yes, that should be fixed.
Ideally it should use a string instead of hardcoding shifts.



More information about the stable mailing list