[dpdk-stable] [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx offloads flags

[Sachin Saxena]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Monday, November 11, 2019 9:27 PM
> To: Sachin Saxena <sachin.saxena at nxp.com>
> Cc: dev at dpdk.org; ferruh.yigit at intel.com; stable at dpdk.org
> Subject: Re: [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx
> offloads flags
> 
> 11/11/2019 16:36, Sachin Saxena:
> > The JUMBO frame handling in dpaa2_dev_mtu_set api was not correct.
> > When frame_size is greater than RTE_ETHER_MAX_LEN, the intention is to
> > add JUMBO flag in rx offload while it was resetting all other flags
> > other than JUMBO as AND operator was used instead of OR.
> 
> Hi,
> About the title of this patch:
> - "fixes" should be "fix" (infinitive verb)
> - "issue" is not needed after "fix"
> - we don't care whether it is "accidentally resetting"
> You should just tell what is fixed and what is the case:
> 	fix Rx offload flags on jumbo MTU set
> 
[Sachin Saxena] Thanks for information. I got your point.