[dpdk-stable] [PATCH] power: handle frequency increase with turbo disabled
Hunt, David
david.hunt at intel.com
Thu Nov 14 17:23:51 CET 2019
Hi Mattias,
On 14/11/2019 14:10, Mattias Rönnblom wrote:
> Calling pstate's or acpi's rte_power_freq_up() when on the highest
> non-turbo frequency results in an error, if turbo is disabled. The
> error is in the form of a return code and a RTE_LOG() entry on the ERR
> level.
>
> According to the API documentation, the frequency is scaled up
> "according to the available frequencies". In case turbo is disabled,
> that frequency is not available. This patch's rte_power_freq_up()
> behaviour is also consistent with how rte_power_freq_max() is
> implemented (i.e. the highest non-turbo frequency is set, in case
> turbo is disabled).
>
> Fixes: 445c6528b55f ("power: common interface for guest and host")
> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
> Cc: stable at dpdk.org
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom at ericsson.com>
> ---
Thanks for the patch, I can repeat the issue without the patch, and
after applying the patch, I no longer get the error message. So:
Tested-by: David Hunt <david.hunt at intel.com>
It might be worth clarifying in the commit message that "turbo
disabled"actually means "turbo enabled in the bios, but disabled via the
power library", but that's a small point.
Acked-By: David Hunt <david.hunt at intel.com>
More information about the stable
mailing list