[dpdk-stable] [dpdk-dev] [PATCH v4] test: optimise fd closing in forked test process
Kevin Traynor
ktraynor at redhat.com
Thu Nov 14 20:31:48 CET 2019
On 12/11/2019 20:31, David Marchand wrote:
> From: Krzysztof Kanas <kkanas at marvell.com>
>
> Caught while investigating timeouts on a ARM64 server.
>
> Stracing a test process running the eal_flags_autotest, we can see that
> the fork helper is checking all possible file descriptors from
> getdtablesize() to 2, and close the existing ones.
> We can do better by inspecting this forked process /proc/self/fd
> directory.
>
> Besides, checking file descriptors via /proc/self/fd only makes sense for
> Linux. This code was a noop on FreeBSD.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable at dpdk.org
>
> Signed-off-by: Krzysztof Kanas <kkanas at marvell.com>
> Signed-off-by: David Marchand <david.marchand at redhat.com>
Seems to be an improvement on what is existing.
Acked-by: Kevin Traynor <ktraynor at redhat.com>
More information about the stable
mailing list