[dpdk-stable] patch 'examples/fips_validation: fix null dereferences' has been queued to LTS release 18.11.6

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/29/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/516d5762d5dc008885d084d659c6b62d86f50cbe

Thanks.

Kevin.

---
>From 516d5762d5dc008885d084d659c6b62d86f50cbe Mon Sep 17 00:00:00 2001
From: Chaitanya Babu Talluri <tallurix.chaitanya.babu at intel.com>
Date: Wed, 25 Sep 2019 07:31:34 +0100
Subject: [PATCH] examples/fips_validation: fix null dereferences

[ upstream commit 75b3dddf95ea0d5a1356115f748e1cc43de67886 ]

One issue caught by Coverity 343408
*deref_parm: Directly dereferencing parameter val->val.

In writeback_tdes_hex_str(), tmp_val is initialised to null.
tmp_val.val is updated only if keys are found.
If keys are not found,it doesn't fails but continues
to invoke writeback_hex_str(),where val->val is accessed
without null check.

The fix is to return the error,
if keys are not found in writeback_tdes_hex_str().

Coverity issue: 343408
Fixes: 527cbf3d5e ("examples/fips_validation: support TDES parsing")

Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu at intel.com>
Acked-by: Akhil Goyal <akhil.goyal at nxp.com>
---
 examples/fips_validation/fips_validation_tdes.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/examples/fips_validation/fips_validation_tdes.c b/examples/fips_validation/fips_validation_tdes.c
index 15ee434e1..2b262c9a0 100644
--- a/examples/fips_validation/fips_validation_tdes.c
+++ b/examples/fips_validation/fips_validation_tdes.c
@@ -213,4 +213,6 @@ writeback_tdes_hex_str(const char *key, char *dst, struct fips_val *val)
 	else if (strstr(key, KEY3_STR))
 		tmp_val.val = val->val + 16;
+	else
+		return -EINVAL;
 
 	return writeback_hex_str(key, dst, &tmp_val);
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-11-22 14:36:57.022847702 +0000
+++ 0034-examples-fips_validation-fix-null-dereferences.patch	2019-11-22 14:36:55.202149179 +0000
@@ -1 +1 @@
-From 75b3dddf95ea0d5a1356115f748e1cc43de67886 Mon Sep 17 00:00:00 2001
+From 516d5762d5dc008885d084d659c6b62d86f50cbe Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 75b3dddf95ea0d5a1356115f748e1cc43de67886 ]
+
@@ -20 +21,0 @@
-Cc: stable at dpdk.org