[dpdk-stable] [dpdk-dev] [PATCH] malloc: fix memory element size in case of padding

Thomas Monjalon thomas at monjalon.net
Tue Nov 26 00:24:54 CET 2019


21/11/2019 16:14, Burakov, Anatoly:
> On 21-Nov-19 2:25 PM, Xueming Li wrote:
> > This patch fixes wrong inner memory element size when joining two
> > elements.
> > 
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: Xueming Li <xuemingl at mellanox.com>
> > ---
> > --- a/lib/librte_eal/common/malloc_elem.c
> > +++ b/lib/librte_eal/common/malloc_elem.c
> > @@ -487,6 +487,10 @@ join_elem(struct malloc_elem *elem1, struct malloc_elem *elem2)
> >   	else
> >   		elem1->heap->last = elem1;
> >   	elem1->next = next;
> > +	if (elem1->pad) {
> > +		struct malloc_elem *inner = RTE_PTR_ADD(elem1, elem1->pad);
> > +		inner->size = elem1->size - elem1->pad;
> > +	}
> >   }
> 
> Reviewed-by: Anatoly Burakov <anatoly.burakov at intel.com>

I don't understand this patch.
The variable inner is never used.
What am I missing?




More information about the stable mailing list