[dpdk-stable] 18.11.3 (LTS) patches review and test

[Kevin Traynor]

On 08/10/2019 11:22, Yu, PingX wrote:
> Kevin,
> FYI. All build are passed in 18.11.3-RC2 except Win10 no support. No issues are found now.
> 

Great, thanks for confirming Ping.

Kevin.

> Regards,
> Yu Ping
> 
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor at redhat.com] 
> Sent: Thursday, October 3, 2019 9:30 PM
> To: Yu, PingX <pingx.yu at intel.com>; stable at dpdk.org; dev at dpdk.org
> Cc: Akhil Goyal <akhil.goyal at nxp.com>; Ali Alnubani <alialnu at mellanox.com>; Walker, Benjamin <benjamin.walker at intel.com>; David Christensen <drc at linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal at nxp.com>; Stokes, Ian <ian.stokes at intel.com>; Jerin Jacob <jerinj at marvell.com>; Mcnamara, John <john.mcnamara at intel.com>; Ju-Hyoung Lee <juhlee at microsoft.com>; Luca Boccassi <bluca at debian.org>; Pei Zhang <pezhang at redhat.com>; Xu, Qian Q <qian.q.xu at intel.com>; Raslan Darawsheh <rasland at mellanox.com>; Thomas Monjalon <thomas at monjalon.net>; Peng, Yuan <yuan.peng at intel.com>; Chen, Zhaoyan <zhaoyan.chen at intel.com>
> Subject: Re: 18.11.3 (LTS) patches review and test
> 
> On 26/09/2019 08:41, Yu, PingX wrote:
>> Kevin,
>> FYi.
>>>   2. [dpdk-stable 18.11.3] meson build error on ub1604-i86
>> Q1: What are the error logs? 
>> Please see below Error info.
>>
>> Q2: Is it a regression for you? i.e. did this test pass with 18.11.2?
>> No, it isn't a regression. We don't test it on 18.11.1 and 18.11.2 before, another the test result is still failed after testing. 
>> dpdk-stable V18.11.2 commitID(06c4b12a5968caea61e96f7d6bd29d2726fbe255)，test failed. 
>> dpdk-stable V18.11.1 commitID(16ece46735c9b70b7033ca7ae095930e9038d9fd)，test failed, the same mistake.
>>
>> Error info：
>> ninja: Entering directory `build-gcc-static'
>> [296/1419] Compiling C object 'drivers/a715181@@tmp_rte_common_dpaax at sta/common_dpaax_dpaax_iova_table.c.o'.
>> FAILED: 
>> drivers/a715181@@tmp_rte_common_dpaax at sta/common_dpaax_dpaax_iova_tabl
>> e.c.o gcc -Idrivers/a715181@@tmp_rte_common_dpaax at sta -Idrivers 
>> -I../drivers -Idrivers/common/dpaax -I../drivers/common/dpaax -I. 
>> -I../ -Iconfig -I../config -Ilib/librte_eal/common 
>> -I../lib/librte_eal/common -Ilib/librte_eal/common/include 
>> -I../lib/librte_eal/common/include 
>> -Ilib/librte_eal/common/include/arch/x86 
>> -I../lib/librte_eal/common/include/arch/x86 
>> -I../lib/librte_eal/linuxapp/eal/include 
>> -Ilib/librte_eal/linuxapp/eal/../../../librte_compat 
>> -I../lib/librte_eal/linuxapp/eal/../../../librte_compat 
>> -Ilib/librte_eal -I../lib/librte_eal 
>> -Ilib/librte_kvargs/../librte_eal/common/include 
>> -I../lib/librte_kvargs/../librte_eal/common/include 
>> -Ilib/librte_kvargs -I../lib/librte_kvargs -Ilib/librte_compat 
>> -I../lib/librte_compat -fdiagnostics-color=always -pipe 
>> -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include 
>> rte_config.h -Wsign-compare -Wcast-qual -Wno-pointer-to-int-cast -fPIC 
>> -march=native -D_GNU_SOURCE -DALLOW_EXPERIMENTAL_API -MD -MQ 
>> 'drivers/a715181@@tmp_rte_common_dpaax at sta/common_dpaax_dpaax_iova_tab
>> le.c.o' -MF 
>> 'drivers/a715181@@tmp_rte_common_dpaax at sta/common_dpaax_dpaax_iova_tab
>> le.c.o.d' -o 
>> 'drivers/a715181@@tmp_rte_common_dpaax at sta/common_dpaax_dpaax_iova_tab
>> le.c.o' -c ../drivers/common/dpaax/dpaax_iova_table.c
>> In file included from ../drivers/common/dpaax/dpaax_iova_table.c:8:0:
>> ../drivers/common/dpaax/dpaax_iova_table.c: In function ‘read_memory_node’:
>> ../drivers/common/dpaax/dpaax_logs.h:18:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__off64_t {aka long long int}’ [-Werror=format=]
>>   rte_log(RTE_LOG_DEBUG, dpaax_logger, "dpaax: %s():  " fmt "\n", \
>>                                        ^
>> ../drivers/common/dpaax/dpaax_iova_table.c:102:2: note: in expansion of macro ‘DPAAX_DEBUG’
>>   DPAAX_DEBUG("Size of device-tree mem node: %lu", statbuf.st_size);
>>   ^
>> ../drivers/common/dpaax/dpaax_logs.h:18:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__off64_t {aka long long int}’ [-Werror=format=]
>>   rte_log(RTE_LOG_DEBUG, dpaax_logger, "dpaax: %s():  " fmt "\n", \
>>                                        ^
>> ../drivers/common/dpaax/dpaax_iova_table.c:121:3: note: in expansion of macro ‘DPAAX_DEBUG’
>>    DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)",
>>    ^
>> cc1: all warnings being treated as errors [301/1419] Compiling C object 'lib/76b5a35@@rte_pipeline at sta/librte_pipeline_rte_table_action.c.o'.
>> ninja: build stopped: subcommand failed.
>>
> Thanks Yu Ping, I reproduced and applied the commits to fix this. It should be fixed now in RC2 (see other mail). If you could re-run this test to confirm same for you, that would be great.
> 
> Kevin.
>