[dpdk-stable] [PATCH v1] app/testpmd: fix CRC strip config error

[Xu, Ting]

Hi, Ferruh,

From the log in Commit e5db17a1e54e, I thought crc_strip was still available in command "port config <id> rx_offload ...", so I did such modification.
Since it was removed, I will rework on it.
There is no problem on 'keep_crc'.

Thanks!

-----Original Message-----
From: Yigit, Ferruh 
Sent: Monday, October 14, 2019 8:29 PM
To: Xu, Ting <ting.xu at intel.com>; dev at dpdk.org
Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Iremonger, Bernard <bernard.iremonger at intel.com>; stable at dpdk.org
Subject: Re: [dpdk-stable] [PATCH v1] app/testpmd: fix CRC strip config error

On 10/12/2019 1:18 PM, Ting Xu wrote:
> This patch fixed the bug that an error appears when config rx_offload 
> crc_strip using command "port config all crc-strip on|off". The reason 
> is that this command was removed previously. However, the current 
> command does not enable "crc_strip" option properly, so that testpmd 
> returns error when config crc_strip.

"port config all crc-strip ..." is already removed, Commit e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands")

And 'crc_strip' seems left over for the "port config <id> rx_offload ..."
command, instead of fixing it should be removed, and 'keep_crc' should be used, "port config <id> rx_offload keep_crc on|off"

Did you observe any problem on 'keep_crc' ?

> 
> In this patch, an additional operation is added to recognize "crc_strip"
> option, since "crc_strip" and "keep_crc" are using the same flag 
> "DEV_RX_OFFLOAD_KEEP_CRC". The current command is "port config 
> <port_id> rx_offload crc_strip on|off".
> 
> Fixes: e5db17a1e54e ("app/testpmd: remove duplicated Rx offload 
> commands")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Ting Xu <ting.xu at intel.com>

<...>