[dpdk-stable] [EXT] Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

[Pavan Nikhilesh Bhagavatula]

>-----Original Message-----
>From: David Marchand <david.marchand at redhat.com>
>Sent: Tuesday, October 15, 2019 2:16 PM
>To: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Stephen
>Hemminger <stephen at networkplumber.org>
>Cc: dev <dev at dpdk.org>; Pavan Nikhilesh Bhagavatula
><pbhagavatula at marvell.com>; dpdk stable <stable at dpdk.org>; Aaron
>Conole <aconole at redhat.com>
>Subject: Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one
>when divisor is 32bit
>On Tue, Sep 3, 2019 at 9:17 PM <pbhagavatula at marvell.com> wrote:
>>
>> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
>>
>> Fix off by one error in 64bit reciprocal division when divisor is 32bit.
>>
>> Fixes: 6d45659eacb8 ("eal: add u64-bit variant for reciprocal divide")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
>
>Any review?
>
>Are we missing an update in the unit test to catch this issue?
>Thanks.

We actually caught it in a unit test
>test_reciprocal_division

>
>--
>David Marchand