[dpdk-stable] [dpdk-dev] [PATCH] examples/ntb: fix no return check

David Marchand david.marchand at redhat.com
Sun Oct 27 14:02:56 CET 2019


On Fri, Oct 25, 2019 at 9:03 AM Xiaoyun Li <xiaoyun.li at intel.com> wrote:
> This patch adds return value checking and error handling for
> rte_rawdev_en/dequeue_buffers() and rte_eth_link_get().

Different class of issues are fixed in this patch, but the initial
commit mixed different features too...
Please split your patches in the future.

> Coverity issue: 350247, 350250, 350251, 350252, 350253, 350254
> Fixes: 5194299d6ef5 ("examples/ntb: support more functions")
> Cc: stable at dpdk.org

No need for copying stable, the fixed commit is only in master and was
not a fix itself.

> Signed-off-by: Xiaoyun Li <xiaoyun.li at intel.com>

Applied, thanks.

It is probably worth revisiting this code and validate the malloc()
failures, or rework this and get rid of malloc.


-- 
David Marchand



More information about the stable mailing list