[dpdk-stable] [dpdk-dev] [PATCH] net/ice: fix unexpected link down

[Ye Xiaolong]

Hi, Qi

On 10/29, Qi Zhang wrote:
>Not to turn down link during dev_stop, it will cause the device
>can't be bind by kernel driver after DPDK driver quit.
>
>Fixes: e6161345d8a9 ("net/ice: support link status change")
>Cc: stable at dpdk.org
>
>Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>
>---
> drivers/net/ice/ice_ethdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>index d74675842..ae6eba63e 100644
>--- a/drivers/net/ice/ice_ethdev.c
>+++ b/drivers/net/ice/ice_ethdev.c
>@@ -2277,8 +2277,6 @@ ice_dev_stop(struct rte_eth_dev *dev)
> 	/* Clear all queues and release mbufs */
> 	ice_clear_queues(dev);
> 
>-	ice_dev_set_link_down(dev);
>-

Is this ice specific issue? Calling set_link_down seems correct thing to do in stop
ops, as we can see in other PMDs like i40e, mvneta, ... 

Thanks,
Xiaolong


> 	/* Clean datapath event and queue/vec mapping */
> 	rte_intr_efd_disable(intr_handle);
> 	if (intr_handle->intr_vec) {
>-- 
>2.13.6
>