[dpdk-stable] [PATCH] net/ice: correct key len and queues check for RSS

Simei Su simei.su at intel.com
Wed Oct 30 03:52:25 CET 2019


This patch corrects key_len and queues check. The key_len and queues
are not supported to configure for RSS in rte_flow.

Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
Cc: stable at dpdk.org

Signed-off-by: Simei Su <simei.su at intel.com>
---
 drivers/net/ice/ice_hash.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index f710b97..f78fe42 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -25,8 +25,6 @@
 #include "ice_ethdev.h"
 #include "ice_generic_flow.h"
 
-#define ICE_ACTION_RSS_MAX_QUEUE_NUM 32
-
 struct rss_type_match_hdr {
 	uint32_t hdr_mask;
 	uint64_t eth_rss_hint;
@@ -333,15 +331,15 @@ struct ice_hash_match_type ice_hash_type_list[] = {
 					RTE_FLOW_ERROR_TYPE_ACTION, action,
 					"a nonzero RSS encapsulation level is not supported");
 
-			if (rss->key_len == 0)
+			if (rss->key_len)
 				return rte_flow_error_set(error, ENOTSUP,
 					RTE_FLOW_ERROR_TYPE_ACTION, action,
-					"RSS hash key_len mustn't be 0");
+					"a nonzero RSS key_len is not supported");
 
-			if (rss->queue_num > ICE_ACTION_RSS_MAX_QUEUE_NUM)
+			if (rss->queue)
 				return rte_flow_error_set(error, ENOTSUP,
 					RTE_FLOW_ERROR_TYPE_ACTION, action,
-					"too many queues for RSS context");
+					"a non-NULL RSS queue is not supported");
 
 			/* Check hash function and save it to rss_meta. */
 			if (rss->func ==
-- 
1.8.3.1



More information about the stable mailing list